Giter Club home page Giter Club logo

Comments (3)

mwinkel-dev avatar mwinkel-dev commented on June 24, 2024

Additional testing indicates that the buffer overflow occurs when the full path (less the leaf node) is 125 visible characters. (There are also some new line characters, thus the total output message exceeds 128 characters.)

from mdsplus.

mwinkel-dev avatar mwinkel-dev commented on June 24, 2024

Investigation reveals that there are two bugs in the tcl/tcl_directory.c file.

The buffer overflow occurs when the path length (plus new line characters) exceeds the msg buffer size. This buffer should be increased in both branches: alpha and mdsplus8.
line 177

In the mdsplus8 branch, there is an additional problem because the node name size is specified incorrectly. The node names only have 63 visible characters (i.e., the trailing null character should not be included).
line 133
line 138

from mdsplus.

mwinkel-dev avatar mwinkel-dev commented on June 24, 2024

Clarification: IMAS and OMAS are abstraction layers above MDSplus and other data stores. Thus, it is unlikely that full IMAS and OMAS paths will be mirrored directly in MDSplus.

However, when designing new MDSplus trees, it is possible that some nodes in the tree will use similar names in order to simplify the mapping from MDSplus to IMAS / OMAS. Thus, those new trees will likely encounter this mdstcl buffer overflow bug.

from mdsplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.