max-mapper / adventure-time Goto Github PK

I have tried to set up using the following instructions:

• install and run https://github.com/mafintosh/docker-browser-server
• install and run https://github.com/maxogden/adventure-time (the demo uses get-dat content but you can swap in your own)

I have also installed the https://github.com/mafintosh/docker-adventure-time docker image.

In order to run I am using the following commands:

• Start docker-browser-server: node ./bin.js mafintosh/docker-adventure-time --port 8080 (I had to update some NPM packages to get it node-gyp to compile).
• Start adventure-time: npm run start.

I have the following adventure-time config:

adventureTime({
  guide: "http://maxogden.github.io/get-dat/guide",
  server: "localhost:8080",
  id: Math.random().toString(36).slice(2)
})

If I navigate to http://localhost:8080 docker-browser-server works fine.
If I navigate to http://localhost:9966 adventure-time serves up but I get no output in the console window.

I am receiving the following error when adventure-time is starting the server:

Error: ENOENT: no such file or directory, open '/vagrant/hatchway/node_modules/edit/node_modules/codemirror/lib/codemirror.css' while parsing file: /vagrant/hatchway/node_modules/edit/index.js

Which is odd because I have double checked and the file is there...? But I can not see how this would effect the console anyway as codemirror is only used for the editor.

@maxogden & @mafintosh I know you guys haven't worked on either of these projects in awhile but I thought I would tag you in just in case you have some insight sorry if this bothers you! :L

BTW the tech you guys have put together is pretty amazing, couldn't believe it when I actually ran a terminal emulator in my browser :)

term.js is no longer maintained - it would be good for long term support to move to the maintained fork, xterm.js.

I'll send a PR for this.

When launching a Docker container from the terminal, I can add switches to limit CPU & Memory like this: docker run --cpus=1 --memory=2g -it container

Is there a way to do this with the containers that launch in the browser?

Easier to access.

I noticed the nodeschool workshop linked here, so I tried to play, but maybe this is a known issue and just hasn't gotten done yet.

I think the third step in the installation instructions should explicitly show how to install adventure-time:

npm install -g adventure-time

I'm not sure how to actually run it though. The other nodeschool stuff creates a script with the same name as the module and links it in the same way. So I expected to just type:

adventure-time

and have it do the next thing like start up a new server and tell me what port to point my browser at.

hi all!

thanks for making this great tool available. i am having an issue when I npm start and load the webpage, my local docker server shows:

There's a clear websocket request from the browser to docker host on 8080, which returns with a green 101. The same occurs when using mafintosh/docker-adventure-time or mafintosh/try-dat.

any tips would be appreciated! thanks,

chris

In https://try-dat.com/06-dat-git-partial.html, there’s initially reference to “local terminal” and then to “source terminal”. Unless I’m mistaken, these are referring to the same terminal instance. We should stick to one or the other.

Similarly, in https://try-dat.com/05-website.html, both “virtual terminal” and “source terminal” are used.

In https://try-dat.com/02-link.html, the first qualification of terminals is made as there’s a source and destination terminal. Before that point, we use the generic term “terminal”.

I’d suggest that when a distinction between terminals doesn’t need to be made, we should simply refer to “the terminal” and when it does, to consistently name and refer to them so as not to confuse readers.

Will send a basic PR in a few moments.

I think the idea is great to demonstrate dat, but it ain't working here in Switzerland. Mac. Chrome.

Screenshot

Approximately 3/4 times I load http://rik.smith-unna.com/command_line_bootcamp, the file tree fails to populate (see command-line-bootcamp/cli-boot.camp#10).

expose-fs is working fine - when the error happens I can retrieve the JSON response manually.

My best guess is that the tree is trying to populate itself before the data source is ready - currently it waits for $(window).ready(). Is there a simple way to load it only after the container is ready? Like maybe connect a socket and only populate the tree after receiving a stdout response, as with the terminal?

Apologies if I've missed something obvious.

$ node index.js
module.js:340
    throw err;
Error: Cannot find module 'term.js'

term.js doesn't seem to be specified as a dependency in package.json, and the file doesn't exist in the adventure-time folder.