mauron85 / background-geolocation-ios Goto Github PK

Xcode 11.3.1 errors when I try to build this plugin, even though Other Linker Flags contains -lsqlite3. I am using capacitor, which includes a compatibility layer for Cordova plugins.

I have tried adding libsqlite.tbd:

And setting CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES:

But neither attempt has worked. However, i did fix it by swapping

-#import "sqlite3.h"
+#import <sqlite3.h>

in both MAURSQLiteLocationDAO.m and MAURSQLiteConfigurationDAO.m.

Would you consider accepting a pull request making this change?

Hi. I'm going to add stopOnTerminate support for ios.
I use locationManager.startMonitoringSignificantLocationChanges in startUpdatingLocation method inMAURDistanceFilterLocationProvider.m so it works fine with DISTANCE_FILTER_PROVIDER when app is terminated.
Should I add stopOnTerminate support in RAW_PROVIDER? I see RAW_PROVIDER already uses locationManager.startMonitoringSignificantLocationChanges in MAURRawLocationProvider.m.

The MAURConfig.m function decodeActivityType has incorrect string comparisons. Now it checks if the value is nonzero, which means the strings are NOT the same, rather than the other way around as it should be. This means that activity type typically ends up at AutomotiveNavigation regardless what you set which leads to map matching / road snapping which you may not want to have. In case I had set the Fitness activity type but strangely got road snapping, that's how I debugged and eventually found the problem. With correct activity applied, road snapping disappeared.

The string comparisons should be changed to if ([....] == NSOrderedSame) { ... } then it will work.

I am most of the way through creating a NativeScript plugin for this library. I have the Android version working as I expect, however, it seems that in the iOS version the location id is always NULL in the onLocationChanged() callback.

See

Shouldn't the location be persisted first then the onLocationChanged callback called with a valid locationId?

This creates inconsistent behaviour with Android when using https://github.com/mauron85/cordova-plugin-background-geolocation, which returns null for these values.

Issue origin:

Opened by: @jumamfa
Platform: cordova
Link to original issue:
mauron85/cordova-plugin-background-geolocation#394

Your Environment

• Plugin version: Latest
• Platform: iOS
• OS version: N/A
• Device manufacturer and model: N/A
• Cordova version (cordova -v): Latest
• Cordova platform version (cordova platform ls): N/A
• Plugin configuration options: N/A
• Link to your project: N/A

Context

Apple Rejection Notice:

Your app uses the "prefs:root=" non-public URL scheme, which is a private entity. The use of non-public APIs is not permitted on the App Store because it can lead to a poor user experience should these APIs change.

Upon scanning all plugins and source of our App, the only area using prefs:root=.... is this one.

Expected Behavior

The plugin should use only public API's so rejections do not occur.

Actual Behavior

The plugin uses non-public API's so rejections do occur.

Possible Fix

I havn't reviewed a potential fix as of yet, however simply stripping the functionality out that makes use of this would be the first step.

Steps to Reproduce

1. Use the plugin.
2. Submit an App to the store.
3. Get rejected.

Context

I was trying to submit an App (infact, many Apps that use this plugin), all of the Apps had the same rejection today.

I test version 0.5.0 on simulator and it doesnt start after phone reboot.
I have used startMonitoringSignificantLocationChanges in #7 only in onTerminated which isn't invoked.
It works okay after reboot if implementation is moved in onStart method. The only difference that MonitoringSignificantLocationChanges will work when the app is in foreground and background. Should we move it to onStart?

Hi!

Have you looked at Flutter? Considered creating a Flutter plugin?
I'm seriously considering moving a relatively small app to Flutter, and looking for a geolocation solution.

If you're interested in working on this together, ping me :-)