matthiaslhk / pe Goto Github PK

On page 11 and 12, there is a part of the text that is split into different pages.

As shown below, the explanation of the Command section is extremely short and does not give much information as the header is very clear cut. So i feel that you can either explain more or just simply remove this part of the UG as it is intutive to the readers what the command section is for.

Same as before, the text is broken and cut off into 2 separate pages.

As can be found on page 5 of the DG. The UML diagram shows many classes and GUI components but almost little or no explanation were given for these classes. For instance, in the UML, there is a class called BudgetCard, but there was no mention of this in the text below or any references made to it.

When i create 2 budget with the exact same name and threshold, no error message is thrown.

Expected: I think that this should not be allowed to happen as there should only be 1 budget and no duplicates are allowed as it does not make sense to allow for duplicates.

As there is a limit of each expenditure not exceeding $10,000. After closing the app, i changed the value of the expenditure to more than the limit and restarted the program and the invalid value was accepted.

Expected: Corrupted file error message detected and start a fresh json file.
Actual: Invalid value accepted into the app

In the Logic class UML diagram, there are notes included in the diagram to help explain the associations but one of the notes used a different line to connect to the UML. This could mean that it is a different type of class or have a different meaning as compared to the other notes, but from what i can see, this is not that case.

After calling the help command, there are a few missing commands in the return message.

Commands such as open are missing. These additional commands are found in the UG but not in the help list.

Same as previously mentioned, the Redo command allows users to enter extra inputs after the command word and no error is thrown.

Expected: Error message stating invalid command
Actual: Successful execution.

The component color used to represent the State and Storage are extremely similar, which was confusing as the readers, me, thought that you have implemented them as a single component, which is not the case. I think you could have choosen another color to represent one of the mentioned components to better differentitate them.

As mentioned previously, this is similar to the previous issue of the words in the images being too small but this is an even more drastic case. The words in the image can barely be seen.

After opening one of the budget and calling the help command, the list of help message does not show the undo and redo commands. This may led the user to think that such commands are not implemented or that is it a bug.

As mentioned in the textbook, the font size of any UML diagrams should be roughly the same size as the text used in the DG. However, in this case, as the diagram is too large to display, it was squeezed to fit into the page, hence making the words in the diagram very small and hard to read. You could have broken the UML into 2 parts to allow better readibility.

When i enterred an expenditure with the tag of "WASTE", the added tag was all in small letters, which is different from what the User Guides shows. In the User guide, the tag is able to reflect captial letters enterred by the user.

Command enterred: add n/paper p/100 t/WASTE
Expected: Tag of "WASTE"
Actual: Tag of "waste"

When enterring the "help" command, the list of help messages are displayed in the results window. As the list of help message is very long and the display window is very small, the user needs to scroll alot to be able to find and see all the help messages.

Same as previously mentioned, the Undo commands accepts the input even if there are extra inputs after the command word. This should not be allowed.

Command executed: undo 12345

Expected: Error message to be thrown for invalid command.
Actual: Accepted

When i added additional inputs after the "list" command, no error was thrown and the command was parsed successfully. I think that this should have been addressed and an error should be thrown to say that the command is invalid.

Command executed: list 123

Expected: An error to be thrown saying that this is an invalid command format.
Actual: Command accepted and executed.

As mentioned in the textbook, the Ui snapshot should not contain too many labels and drawings as it is very messy. In this case, as the image already has a lot of text and graphics, adding more boxes and labels makes the image even harder to read. I think maybe you could have numbered the features and have a legend below to reference ths diagram. Also, the colour of the label boxes are very similar to the background and theme of the app GUI, making it even harder to read.

The command summary does not show all commands, the help, undo and redo commands are missing from the summary table.

The User Guide mentioned that the app can produce stats for the user to see their spending habits but no such feature was mentioned in the UG or in the app itself.

The UML diagram provided for the Ui component is very messy and not well drawn as there are many intersecting lines. What I would suggest is that you could have abstract out those GUI components that are similiar or children of another component into XYZClass.

The app does nto allow users to add any expenditure more than $10,000. But what if there is an item that the user wishes to add that is more than $10,000? Then this app will no longer be useful to the user as only some of this items can be tracked. Especially since the budget and be more than $10,000, it does not make sense the that expenditure cannot.

When i copied the example given in the UG, the results shown are different in the app as compared to the UG.

Command enterred:

Expected: add n/Graphic Calculator p/199.90 t/Math

Actual:

After I open one of the budgets, then i type in the help command. The help message for edit command gave an invalid example as shown below.

Both the sequence diagram are very similar and are hard to read. As such, you could have referenced one of the diagrams and leave out the other as there are almost the same

Add:

delete:

When I enter the delete command with an index of 1.0, the error thrown is that the given value needs to be greater than 0, in this case, it is.

Command executed: delete 1.0

Expected: I think that there should be an error that address this and say decimals are not allowed, please enter an integer.

The explanation and the image referred to are split into 2 different pages.

The help, undo and redo commands are not shown in the command summary of the budget page, which works in the app but is not mentioned in the summary.