How to dispose of Curtains about curtainsjs HOT 1 CLOSED

Hi @joebentaylor,

this.curtains.webGLCurtain.dispose(); won't work because neither this.curtains nor this.curtains.webGLCurtain seem to be defined in your code.

You should probably define this.webGLCurtain in your constructor:

constructor( props ) { super(props); this.webGLCurtain = null; }

and then instanciate the curtains inside your curtains() method like that:
this.webGLCurtain = new Curtains("canvas");

You'll then be able to dispose it that way:
this.webGLCurtain.dispose();

I'm glad you reported that issue because there was indeed a bug in the dispose() method that I fixed now.

Also, working with curtains.js and React, here are a couple of advice I can share:

• You should always remove all event listeners when unmounting your component. You're doing part of the job inside your this.removeAnimation(); method, but you're not removing the resize, mousemove and touchmove events listener added inside onReady().
• I usually create the WebGL context only once inside my App.js file (and I put my <div id="canvas" /> there as well): this.webGLCurtain = new Curtains("canvas"); and then pass it as a prop to the component that defines the planes and stuff. That way you don't have to bother with the context and just have to add and remove the planes on didMount/willUnmount.

I hope that's helpful.

Cheers,

from curtainsjs.