Giter Club home page Giter Club logo

Comments (6)

glennhickey avatar glennhickey commented on June 21, 2024 2

I don't have any ideas of mc changes that would affect Panacus. Here's two yeast graphs made with Cactus v2.6.4 (which was used for the v1.1 HPRC graphs) and Cactus v2.7.0 (which is the current release).

If there's a regression, I would think it would show up between these two graphs.

http://public.gi.ucsc.edu/~hickey/debug/panacus/

from panacus.

danydoerr avatar danydoerr commented on June 21, 2024

Thanks for reporting! Can you provide a graph where I can debug the issue?

from panacus.

danydoerr avatar danydoerr commented on June 21, 2024

Thanks @glennhickey!

from panacus.

danydoerr avatar danydoerr commented on June 21, 2024

Panacus runs smoothly on these graphs (see attached files). @Xuelei-Dai could you describe the specific issue in more detail and provide a graph that does not work with the current release of panacus?

yeast-v2.6.4.histgrowth.all.html.gz
yeast-v2.6.4.histgrowth.all.html.log.gz
yeast-v2.6.4.histgrowth.all.pdf
yeast-v2.6.4.histgrowth.all.tsv.gz
yeast-v2.6.4.histgrowth.all.tsv.log.gz
yeast-v2.7.0.histgrowth.all.html.gz
yeast-v2.7.0.histgrowth.all.html.log.gz
yeast-v2.7.0.histgrowth.all.pdf
yeast-v2.7.0.histgrowth.all.tsv.gz
yeast-v2.7.0.histgrowth.all.tsv.log.gz

from panacus.

Xuelei-Dai avatar Xuelei-Dai commented on June 21, 2024

Thanks @danydoerr and @glennhickey!

In the current version of Mingraph-Cactus (MC), the gfa file does not have P line, and the new W line was changed. Since I referred to the Pangenome Coverage and Growth Statistics pipeline (convert the 1.1 version of gfa to 1.0 (vg convert -gfW)), recently I directly used the 1.1 version of the gfa file as the input of panacus, it's okay. So I suggest that you can add some instructions to your pipeline, for example, how should the gfa 1.1 version be run?

Best,
Xuelei

from panacus.

danydoerr avatar danydoerr commented on June 21, 2024

That's a good point, @Xuelei-Dai, the current README does not contain an example for the MC graph. I have now added an example for the MC graph.

To be perfectly clear, panacus has always supported GFA 1.1 and therefore also the latest MC graphs. Neither any update is required, nor any bug to be fixed. The example in the README suggests to visualize pangenome growth only for a subset of samples (those corresponding to haplotypes). This preprocessing is not part of panacus and remains the responsibility of the users.

from panacus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.