Giter Club home page Giter Club logo

Comments (11)

danydoerr avatar danydoerr commented on July 4, 2024 1

Everything is negotiable... My coding principles are hanging high enough so that I can limbo below every once in a while. If you're not happy with postprocessing, I'm also accepting pull requests with your solution :)

from panacus.

danydoerr avatar danydoerr commented on July 4, 2024

I could add an option to specify the output format (pdf/png). Separate PNGs... what do you mean by that?

from panacus.

subwaystation avatar subwaystation commented on July 4, 2024

The final output is one PDF with 3 Figures, if I am not mistaken.
panacus.pdf
In the MultiQC report, we would like to have 3 separate figures, so we would need each of them in its own PNG file.

from panacus.

subwaystation avatar subwaystation commented on July 4, 2024

The option specifying the output format sounds great!

from panacus.

danydoerr avatar danydoerr commented on July 4, 2024

Regarding the separation of figures: Panacus always produces 1 output file from 1 input file. But if you want to have the figures separated, it's super easy to have this done in a subsequent script that utilizes identify and convert from ImageMagick.

  1. identify gives you the dimensions of the image:
identify panacus.png
panacus.png PNG 9000x1800 9000x1800+0+0 8-bit sRGB 690629B 0.000u 0:00.000
  1. It's clear that each plot has same dimensions, so all you need to do is take with width and divide by 3 for cropping with convert:
convert -crop 3000x1800+0+0 panacus.png panacus1.png
convert -crop 3000x1800+3000+0 panacus.png panacus2.png
convert -crop 3000x1800+6000+0 panacus.png panacus3.png

panacus

from panacus.

danydoerr avatar danydoerr commented on July 4, 2024

(Also, there is a bug in the plotting script that draws the estimate of the 2nd plot at the wrong position; I just pushed a fix)

from panacus.

subwaystation avatar subwaystation commented on July 4, 2024

Yes, we also thought about ImageMagick. But that would mean more work downstream for us. A new nf-core module, more to maintain, etc.
That's why we are wishing for 3 PNGs.
If that's not possible, we will have to go for the ImageMagick option.

from panacus.

subwaystation avatar subwaystation commented on July 4, 2024

Please take a look at https://github.com/marschall-lab/panacus/pull/11/files @danydoerr

from panacus.

danydoerr avatar danydoerr commented on July 4, 2024

@subwaystation Thanks! Very helpful, I only have a few requests that I think will improve the usability.

from panacus.

danydoerr avatar danydoerr commented on July 4, 2024

It's now merged. Again, thanks @heringerp!

from panacus.

danydoerr avatar danydoerr commented on July 4, 2024

@heringerp @subwaystation made a minor change for the prefix argument, which is now called 'split_prefix', to associate it more closely with the split option

from panacus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.