Giter Club home page Giter Club logo

hmp3's People

Contributors

maikmerten avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

hmp3's Issues

Unsupported PCM file type

Dear @maikmerten, recently I have come across a few limitations of Helix MP3 encoder. Both are related to the same error: “UNSUPPORTED PCM FILE TYPE”. Perhaps you could do something about that, since LAME has no such issue.

  1. When input's bit depth is not 16 bit, but 24 bit.
  2. When input's WAV format is not PcmWaveformat, but WaveFormatExtensible.

Accepting PRs?

I have need for helix in an stm32 project and was hoping pull requests might be accepted here if I make any improvements. If so I’m very glad to see someone keeping this code alive as I’ve had good use of this decoder ported to riscv etc for esp32 usage.

No Xing/LAME tag for CBR files

Currently no Xing tag is written for CBR files. That's because tomp3.cpp submits no proper nBitrateIndex:

		head_bytes = XingHeader ( ec.samprate, head.mode,
			ec.cr_bit, ec.original, head_flags, 0, 0,
			vbr_scale, NULL, bs_buffer + bs_bufbytes,
			0,0,0 );

With no proper information on the bitrate, this check fails in xhead.c:

        // use the index already determined from head info - you only have one shot 
        frame_bytes = 144000 * br_table[h_id][nBitRateIndex] / tmp;
        if ( frame_bytes < bytes_required )
            return 0;   //fail, won't fit

(according to br_table there are 0 bytes available)

[Question] Mysterious options

Dear @maikmerten,
Helix serves me well, but I'd like to know more about some of its options.
At present their descriptions leave much to be desired.

A[algor_select]  0 = track input, 1=MPEG-1, 2=MPEG-2, xxxxx=sample_rate

Q         disable_taper, q0 = base, q1 = fast, q-1 = encoder chooses

TX        tx6, test reserved 6 or 8 seems best (startup_adjustNT1B)
            ** v5.0  TEST 1  as of 8/15/00
            ** v5.0  TEST 2  8/18/00
            ** v5.0  TEST 3  default tx6 (prev = tx8)
            ** v5.0  TEST 4  mods to short fnc_sf, ms corr. hf enable > 80
            ** v5.0  TEST 5  fix odd npart, ix clear
            ** v5.0  TEST 6  add reformatted frames
            ** v5.0  TEST 7  drop V4 amod
            ** v5.1  2005.08.09 (see CVS log for details)

SBT[short_block_threshold]
          short_block_threshold default = 700

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.