lukeusmc / ds18b20-photon Goto Github PK

Veryfing code using this library in Particle Build fails with this error ONLY WHEN COMPILING FOR SPARK CORE

DS18B20/DS18B20.h:15:7: error: redefinition of 'class DS18B20'
 class DS18B20{
       ^

In file included from DS18B20/DS18B20.h:1:0,
from measuredisplayt.cpp:5:
This looks like an error in DS18B20 library.

DS18B20/Particle-OneWire.h:125:6: error: #error "*** PLATFORM_ID not supported by this library. PLATFORM should be Core or Photon _"
#error "_ PLATFORM_ID not supported by this library. PLATFORM should be Core or Photon ***"

I am using the SparkFun Photon RedBoard (P1).

As I found out here, there is a potential memory leak when using multiple instances of that library
https://community.particle.io/t/ds18b20-switching-pins-during-execution/25727/15

This is easily fixed with the intrdocution of a destructor

DS18B20::~DS18B20() {
    delete(ds);
}

And if you're at it, could you also replace these macros, please?

• digitalWriteFastHigh()
• digitalWriteFastLow()
• digitalReadFast()

with the now available functions

• pinSetFast(_pin)
• pinResetFast(_pin)
• pinReadFast(_pin)

One the other hand it might even be better to remove the "private" implementatino of OneWire and just add a note to import that dependency (this will make getting this lib ready for Libraries 2.0 easier too).