lucat1 / tempo-server Goto Github PK

Hey @lucat1, Thanks for adopting SeaORM!
It's our pleasure to see more inspirational projects were built on top of SeaORM :)

Let us know if you have any feature recommendation or feedback. Your contribution is what drive us forward!

Some learning resources for you: Documentation, Tutorial, Cookbook, Q&A
Join our Discord server to chat with others in the SeaQL community!

Feel free to submit a PR to showcase your project, SeaQL/sea-orm#403.

Pointed tagger to a directory tree and it crashed:

   info Tagging as:
   info Artist: Amber ArcVades, Andy Shariouf,s Angelo Kelly, Autumn SaArtinsts, Black Belt Eagle Scout, Bruce Springsteen, Bryan Adams, Caroline Polachek, Cat Clyde, Courtney Pine, Dave Meniketti, Delain, Emma Longard, Eric Clapton, Fran, Hania Rani, Humble Pie, Inger Nordvik, Jill Barber, Kevin Morby, Khymera, Laurie Styvers, Lisa O'Neill, Mark Knopfler, Mogwai, P!nk, Paramore, Phil Campbell, Riaan Benade, Robin McAuley, Ron Sexsmith, Ruth Killius, Ruth Moody, Shakey Graves, Simone Kopmajer, Stevie Ray Vaughan, Stevie Ray Vaughan & Double Trouble, T3nors, Tennis, The Brian Jonestown Massacre, The Rolling Stones, Tim Easton, Tygers of Pan Tang, Uriah Heep, Wolfgang Haffner, Yo La Tengo
   info Title: 2023/02/07A Hollywood, FLTribute To Stevie Ray Vaughan (8824b078-a700-4322-b196-53ebf3f899c2)
   info Tracks:
The application panicked (crashed).
Message:  index out of bounds: the len is 12 but the index is 443
Location: cli/src/import.rs:147

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

After 396ce31, following clippy's suggestion to reuse the cmp methods from the Ord trait, the deduplication is no longer working. This means that previously we had a different implementation for partial_cmp and cmp, which is not sane. The cmp implementation will have to be revisited and aligned to the previous partial_cmp code.

Currently, if the music brainz API returns unrelated matches for an import, there is no way for the user to say "i know better" and force the tagger to import the files as another release. The imports API could be extended by allowing a json:api-like insert operation to add a new music brainz release ID. The addition would then be asynchronous and the client would have to wait for its compatibility to be evaluated.

During import, a release which has been tagged as 3e5c83ab-526e-4bad-83ec-a0e5c47c4b27 has had its two discs swapped.
This is a logic bug which should be investigated and fixed.