Giter Club home page Giter Club logo

Comments (4)

lucat1 avatar lucat1 commented on June 19, 2024

Mh, it definitely is a bug, and in debugging the stacktrace obtained with RUST_BACKTRACE=1 would be helpful. If you can provide that, I can probably solve this issue.

One thing I'm guessing based on the indexes and the release on MB is that you're trying to import a folder with many more items than the MB release. This is currently a known issue and won't work, though I'm planning to fix this soon!
For now, the tagger only supports importing a single album at a time, with the exact same number of tracks that the MB release has. Could you try running tagger import on the single album folder?

from tempo-server.

audiomuze avatar audiomuze commented on June 19, 2024

I was attempting to import a directory tree containing many subdirectories, each of which represents an album which may or may not appear in MusicBrainz.

Here's the output with BACKTRACE=1

The application panicked (crashed).
Message:  index out of bounds: the len is 12 but the index is 1031
Location: cli/src/import.rs:147

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 8 frames hidden ⋮                               
   9: core::panicking::panic_bounds_check::h6df9e7ddd727b957
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/panicking.rs:151
  10: cli::import::import::{{closure}}::hd732516fdc6e8497
      at <unknown source file>:<unknown line>
  11: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h5d4f25b8fc528ea1
      at <unknown source file>:<unknown line>
  12: tokio::runtime::park::CachedParkThread::block_on::hefa1b33ffb3d5fe2
      at <unknown source file>:<unknown line>
  13: tokio::runtime::scheduler::multi_thread::MultiThread::block_on::h23e1e5711bd5c1e7
      at <unknown source file>:<unknown line>
  14: tokio::runtime::runtime::Runtime::block_on::hf8d6af22d908a6e7
      at <unknown source file>:<unknown line>
  15: cli::main::hfeae46ee27c2b510
      at <unknown source file>:<unknown line>
  16: std::sys_common::backtrace::__rust_begin_short_backtrace::he6042d15c2f9541f
      at <unknown source file>:<unknown line>
  17: std::rt::lang_start::{{closure}}::h98123ee924bc7b81
      at <unknown source file>:<unknown line>
  18: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h072eb4cd8da964ba
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/ops/function.rs:286
  19: std::panicking::try::do_call::h8eca204fe9266946
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panicking.rs:483
  20: std::panicking::try::h12574e1b7b2cbacb
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panicking.rs:447
  21: std::panic::catch_unwind::hf71522d4448329d6
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panic.rs:137
  22: std::rt::lang_start_internal::{{closure}}::h65b66ac9bff580f8
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/rt.rs:148
  23: std::panicking::try::do_call::hfff61e33ca3db9f1
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panicking.rs:483
  24: std::panicking::try::he48c8ecead279cad
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panicking.rs:447
  25: std::panic::catch_unwind::hd510a26bfc950ccc
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/panic.rs:137
  26: std::rt::lang_start_internal::hc680b25eab888da9
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/std/src/rt.rs:148
  27: main<unknown>
      at <unknown source file>:<unknown line>
  28: __libc_start_main<unknown>
      at <unknown source file>:<unknown line>
  29: _start<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.

It works when run against a single album.

from tempo-server.

lucat1 avatar lucat1 commented on June 19, 2024

I was attempting to import a directory tree containing many subdirectories, each of which represents an album which may or may not appear in MusicBrainz.

Then, this is expected, although it should be handled more nicely.
The import command is meant to import one and only one album at a time. Unfortunately, this is the way it's planned to work. I explicitly don't want to do any grouping based on artists as they often get pretty messy. Grouping based on directory depth (assuming all files in a directory are in the same album) has the same flaws. So for now, it's going to stay this way and you'll have to run a tagger import for each release you want to tag.

from tempo-server.

lucat1 avatar lucat1 commented on June 19, 2024

I'm closing this as the importing process has changed significantly. Still, this feature is not yet available but it's not of the highest priority. If you would like to import multiple releases at a time, please open a feature request specifically for that.

from tempo-server.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.