Comments (5)
I fixed the unit tests. The RemoveGenerator service seems to be right. The poblem is the calling prozess (perhaps)
from sourceopt.
Could you run some debugging in the middleware: CleanHtmlMiddleware
from sourceopt.
Will run it the next days on the newest dev version and report back.
How to run debugging in the middleware? Just turning on debug or anything special?
from sourceopt.
Check if the condition works:
https://github.com/lochmueller/sourceopt/blob/master/Classes/Middleware/CleanHtmlMiddleware.php#L35
if the right configuration is assigned (your TS):
https://github.com/lochmueller/sourceopt/blob/master/Classes/Middleware/CleanHtmlMiddleware.php#L43
and the return of the processed Output:
https://github.com/lochmueller/sourceopt/blob/master/Classes/Middleware/CleanHtmlMiddleware.php#L48
from sourceopt.
Hey Martin,
no feedback in the last days. I double checked this in my TYPO3 v 9 instance. First I missed to include the static TypoScript. After I include the Static TypoScript there are the right "$manipulations" objects in this place https://github.com/lochmueller/sourceopt/blob/master/Classes/Service/CleanHtmlService.php#L131 and the generator is also dropped.
Please test your env and create a new issue if you have some more details. I need ifnormation if this is a problem of the manipulation class or of the activation process, if the problem still exists. I close this issue, because I cannot rebuild this problem currently.
Regads,
Tim
from sourceopt.
Related Issues (20)
- [BUG] PHP 8.1 Undefined array key HOT 6
- 4.0.5 and TYPO3 11 doesn't minify HTML HOT 2
- PHP Runtime Deprecation Notice if svgstore is enabled HOT 10
- Support TYPO3 v12 HOT 3
- Bug in JSON-Escaping HOT 5
- [BUG] Split html into it's elements HOT 2
- TYPO3 v10 compatibility HOT 5
- New changes HOT 1
- Please support TYPO3 v11 HOT 3
- composer.json and release notes mismatch wrt. PHP version HOT 1
- TypeError with 4.0 due to wrong array access
- Sourceopt destroys XML-Sitemap & RSS feed (blog extension) HOT 3
- SVGStore must not apply to <picture><img src="pic.svg"></picture> HOT 5
- Undefined array key "svgstore." HOT 2
- Exception: ... SvgStoreService::addFileToSpriteArr() must be of the type array or null ... HOT 4
- Problem with special Pagetype HOT 3
- Php 7.3 support HOT 3
- Query in SvgFileRepository not compatible with sql_mode=only_full_group_by HOT 3
- Breaks Ext:cart Ajax functionality HOT 6
- PHP version constraint in ext_emconf.php doesn't match version constraint in composer.json HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sourceopt.