PHP Runtime Deprecation Notice if svgstore is enabled about sourceopt HOT 10 CLOSED

aber gern 😄

from sourceopt.

from sourceopt.

@bavarianbytes can not re-create this notice @ TYPO3 11.5.16 / PHP 8.1 ; did you try dev-master?

from sourceopt.

I also don't saw the error... but I suggest to avoid assignments in conditions. Perhaps we should avoid the double assignment in this condition to increase the readability of the code?!

from sourceopt.

@bavarianbytes Please check again current master. If the problem is still there, please send us a note...

from sourceopt.

Thanks, tried the current master. The exception is caused by line 162 now:
$this->svgFileArr[$file['path']] = $file['defs'];

Full Exception:

at TYPO3\CMS\Core\Error\ErrorHandler->handleError(8192, 'Automatic conversion of false to array is deprecated', '/Users/***/typo3conf/ext/sourceopt/Classes/Service/SvgStoreService.php', 162)
in /Users/***/typo3conf/ext/sourceopt/Classes/Service/SvgStoreService.php line 162
            $file['path'] = '/'.$storageArr[$file['storage']].$file['identifier']; // ^[/]
            $file['defs'] = $this->addFileToSpriteArr($file['sha1'], $file['path']);

            if (null !== $file['defs']) {
                $this->svgFileArr[$file['path']] = $file['defs'];
            }
        }
        unset($storageArr, $storage, $fileArr, $file); // save MEM

from sourceopt.

please add a var_dump($file); in line [160] and past the output here - thx

from sourceopt.

var_dump($file);

array(5) { ["storage"]=> int(1) ["identifier"]=> string(27) "/demo/logos/basic_ipsum.svg" ["sha1"]=> string(40) "05cef80e9b3ba6573a0a9d7ee11388caedf5e03e" ["path"]=> string(37) "/fileadmin/demo/logos/basic_ipsum.svg" ["defs"]=> array(2) { ["attr"]=> string(22) "viewBox="0 0 1998 434"" ["hash"]=> string(40) "05cef80e9b3ba6573a0a9d7ee11388caedf5e03e" } }

from sourceopt.

found it ; FIX @ https://github.com/lochmueller/sourceopt/pull/107/files << you may try it manually

from sourceopt.

Works! Thank you!

from sourceopt.