Comments (3)
Puuuhhh... It's long ago all the regex stuff ;) I will check this in the next days/weeks..
https://github.com/lochmueller/sourceopt/blob/master/Classes/Service/CleanHtmlService.php#L453
from sourceopt.
I looked into the function removeNewLines()
. For me it looks like there are no calls to this function removeNewLines()
.
https://github.com/lochmueller/sourceopt/blob/master/Classes/Service/CleanHtmlService.php#L453
The input
-tags get cleaned in the function formatHtml()
by calling the function killLineBreaks()
https://github.com/lochmueller/sourceopt/blob/master/Classes/Service/CleanHtmlService.php#L281
I gave it a try to fix it. Please have a look at
https://gist.github.com/rr-it/03869b8a3a5c804e12aadc9aa46dce02
(diff: https://gist.github.com/rr-it/ab6a02a8b0d979b69d7ec687081a2c4e)
Instead of calling function killLineBreaks()
it is calling function removeNewLines()
now. The function removeNewLines()
calls function killLineBreaks()
if necessary.
https://gist.github.com/rr-it/03869b8a3a5c804e12aadc9aa46dce02#file-cleanhtmlservice-php-L282
The function removeNewLines()
is totally changed
https://gist.github.com/rr-it/03869b8a3a5c804e12aadc9aa46dce02#file-cleanhtmlservice-php-L455
First I did some restructuring - this hopefully did not change any programmatic logics.
https://gist.github.com/rr-it/f909a7c78bf38825f64ab5d914ee6e5a
With the new structure in place, I extended the function to recognize the value
-attribute of input
-tags. Then, if necessary, the function killLineBreaks()
gets called.
from sourceopt.
I close this issue... I suggest a Middleware solution instead of EXT:sourceopt.
from sourceopt.
Related Issues (20)
- [BUG] PHP 8.1 Undefined array key HOT 6
- 4.0.5 and TYPO3 11 doesn't minify HTML HOT 2
- PHP Runtime Deprecation Notice if svgstore is enabled HOT 10
- Support TYPO3 v12 HOT 3
- Bug in JSON-Escaping HOT 5
- PHP Runtime Deprecation Notice HOT 5
- Exception if $html is empty in SvgStoreService->process HOT 14
- Idea/feature request: cache SVGs with gradients HOT 6
- HTML\Sourceopt\Service\CleanHtmlService::formatHtml(): Argument #1 ($html) must be of type string, null given HOT 1
- Undefined array key "body" HOT 6
- PHP warning: undefined array key "svgstore" in ../ ../SvgStoreMidddleeware.php. HOT 4
- PHP Runtime Deprecation Notice: Creation of dynamic property HTML\Sourceopt\Service\SvgStoreService::$svgFileArr is deprecated in /.../lochmueller/sourceopt/Classes/Service/SvgStoreService.php line 71 HOT 8
- Undefined array key "replacer." RegExRepMiddleware.php HOT 1
- preg_replace_callback(): Argument #3 ($subject) must be of type array|string, null given HOT 4
- if "pathType" is not defined, a PHP warning is thrown HOT 9
- Problem with special Pagetype HOT 3
- Php 7.3 support HOT 3
- Query in SvgFileRepository not compatible with sql_mode=only_full_group_by HOT 3
- Breaks Ext:cart Ajax functionality HOT 6
- PHP version constraint in ext_emconf.php doesn't match version constraint in composer.json HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sourceopt.