lminhtm / lmgeocoder Goto Github PK

When calling either of the following two geocoding methods on a thread other than the main thread, they fail to call their completion handlers (or do anything for that matter):

- (void)geocodeAddressString:(NSString *)addressString service:(LMGeocoderService)service completionHandler:(LMGeocodeCallback)handler;
- (void)reverseGeocodeCoordinate:(CLLocationCoordinate2D)coordinate service:(LMGeocoderService)service  completionHandler:(LMGeocodeCallback)handler;

A fix for this issue would allow for calls on background threads (e.g. when performing a background refresh, or to avoid blocking the UI). In the meantime, you may want to consider adding a documentation note in the header:

@note This method should only be called on the main thread. Calling this method on any other thread will fail.

Additionally, you may want to implement a runtime catch for this and write a warning to the log:

if (![NSThread isMainThread]) {
    NSLog(@"[LMGeocoder] Warning, geocodeAddressString:service:completionHandler: must be called on the main thread. The completion handler will not be called.");
    return;
}

Hello, I want to use your library for a dynamic geocoding, but can't find a way to do it

Ko get được location trên iOS 8 bạn ơi ^_^

Hello,

I am using your library but getting _subLocality null.

Can you please check for the same.

I am using the below coordinate.

(CLLocationCoordinate2D) coordinate = (latitude = 23.010400000000001, longitude = 72.515100000000004)

Thanks,

I installed using LMGeoCoder and gives me error duplicate declaration on each n every property and class.
I have recheck my complete code and there is not duplicate existence of this class.
Do anyone know what could be the issue?

Hi! Thanks for really nice component.
Could you please consider adding full original info into LMAddress object, it could be just dictionary property. So for example I need viewport coordinate received from Google API to show on map, but it's not parsed in LMAddress and there is no ability to access original Google API response.

I can submit a quick PR for this.
Thanks.

This is amazingly easy to use. I was expecting to have to provide my own googleAPIKey. How does it work without one? Am I going to run into problems if I don't provide it? If so, then what if I were using the Apple service? Would I need an API key for that? Thank you!

By the way, here's the swift code I'm using, in case you want to add it:

LMGeocoder.sharedInstance().geocodeAddressString(addressString, service: .GoogleService, completionHandler: { (results, error) -> Void in
    if results != nil, let address = results.first as? LMAddress {
        print("Coordinate: (%f, %f)", address.coordinate.latitude, address.coordinate.longitude)
    } else if error != nil {
        print("Geocoding error: \(error.localizedDescription)")
    } else {
        print("No results found")
    }
})

Hello
I found some missing code parts.

1. on line 109 of LMGeocoder.m file
   replace
   [self parseGeocodingResponseResults:placemarks service:kLMGeocoderAppleService];
   to
   NSArray *finalResults = [self parseGeocodingResponseResults:placemarks service:kLMGeocoderAppleService];
   if (handler) {
   handler(finalResults, nil);
   }

2. on line 207 of LMGeocoder.m file
   replace
   [self parseGeocodingResponseResults:placemarks service:kLMGeocoderAppleService];
   to
   NSArray *finalResults = [self parseGeocodingResponseResults:placemarks service:kLMGeocoderAppleService];
   if (handler) {
   handler(finalResults, nil);
   }