Android `setOrientationBis` issues about sdl HOT 6 OPEN

Looking at the code, it seems like it will do what you want if the window is resizable, right? Here:

from sdl.

Looking at the code, it seems like it will do what you want if the window is resizable, right?

You're right - I didn't notice I was missing that flag in my window creation 🤦🏼‍♂️ Thanks!

from sdl.

I did find another bug though. If choosing between a flipped, or not, version of landscape / portrait, the user setting isn't respected, so it will always use the sensor, regardless of user's auto rotate setting. So, if it's a full 360 rotation, that works fine, and respects the user's auto rotate. But landscapeLeft & landscapeRight will always be sensor, ignoring user's auto rotate. Does that make sense?

from sdl.

Patches welcome!

from sdl.

I'll have a bash at a fix later - it's making me go cross-eyed at the moment.

from sdl.

07636ac fixes the user's auto-rotate issue, but I found yet another problem in the logic:

SDL_SetHint(SDL_HINT_ORIENTATIONS, "LandscapeLeft LandscapeRight Portrait"); will allow PortraitUpsideDown, because there's no distinction between one portrait and both landscape (and visa versa... one landscape and both portraits) when deciding to allow all orientations (hope that makes sense). I don't see a way to actually fix this without looking to see if we're attempting to get landscape or portrait. setOrientationBis() is flawed; a different approach is needed.

from sdl.