Comments (6)
These warnings appeared because you configured SDL without ibus or fcitx support.
They did not occur on ci because those development packages are always installed.
We do not have a way to test every permutation.
This will fix your warning, but I don't know whether this is the correct fix:
--- a/src/video/x11/SDL_x11events.c
+++ b/src/video/x11/SDL_x11events.c
--- a/src/video/x11/SDL_x11events.c
+++ b/src/video/x11/SDL_x11events.c
@@ -884,12 +884,14 @@ void X11_HandleKeyEvent(SDL_VideoDevice *_this, SDL_WindowData *windowdata, SDL_
text[0] = '\0';
if (SDL_TextInputActive()) {
+#if defined(HAVE_IBUS_IBUS_H) || defined(HAVE_FCITX)
/* Save the original keycode for dead keys, which are filtered out by
the XFilterEvent() call below.
*/
int orig_event_type = xevent->type;
KeyCode orig_keycode = xevent->xkey.keycode;
+#endif
/* filter events catches XIM events and sends them to the correct handler */
if (X11_XFilterEvent(xevent, None)) {
#if 0
@slouken touched this in 658f3cd
from sdl.
I see -- so should I just report these issues in the future like this then?
from sdl.
Yes please!
Being correct and warning-free remaing a goal.
I was merely explaining why the warning did not appear on ci.
from sdl.
These warnings appeared because you configured SDL without ibus or fcitx support. They did not occur on ci because those development packages are always installed. We do not have a way to test every permutation.
This will fix your warning, but I don't know whether this is the correct fix:
--- a/src/video/x11/SDL_x11events.c +++ b/src/video/x11/SDL_x11events.c --- a/src/video/x11/SDL_x11events.c +++ b/src/video/x11/SDL_x11events.c @@ -884,12 +884,14 @@ void X11_HandleKeyEvent(SDL_VideoDevice *_this, SDL_WindowData *windowdata, SDL_ text[0] = '\0'; if (SDL_TextInputActive()) { +#if defined(HAVE_IBUS_IBUS_H) || defined(HAVE_FCITX) /* Save the original keycode for dead keys, which are filtered out by the XFilterEvent() call below. */ int orig_event_type = xevent->type; KeyCode orig_keycode = xevent->xkey.keycode; + /* filter events catches XIM events and sends them to the correct handler */ if (X11_XFilterEvent(xevent, None)) { #if 0
This is the correct fix, please feel free to commit. Thanks!
from sdl.
Yes please! Being correct and warning-free remaing a goal. I war merely explaining why the warning did not appear on ci.
Ok! thanks
from sdl.
This is fixed in cf267e4
Thanks!
from sdl.
Related Issues (20)
- SDL_Event.key and kdevice does not return expected IDs? HOT 12
- testcamera does not work on emscripten HOT 2
- [Feature Request] Add Handheld and Custom device capability and feature support
- SDL_DestroyTexture leak memory wayland X11. HOT 2
- SDL3 Android SIGSEGV in `ANDROID_JoystickRumble` after `SDL_Quit` HOT 1
- testffmpeg poor performance HOT 11
- dummy audio driver does not work on emscripten HOT 6
- Memory leaks SDL_stack_alloc/SDL_stack_free HOT 4
- SDL return code -> SDL_bool? HOT 23
- [Windows 10] Most joystick events do not show up unless initalized with SDL_INIT_VIDEO HOT 1
- Clarify initial content of surfaces and textures HOT 1
- make src/libm a static library internal to SDL ? HOT 18
- [Android] mouse - avoid popping out system bars HOT 1
- Remove unused math code from MSVC and Xcode projects
- ios: infinite hang on SDL_malloc HOT 2
- Windows VC Linker error audio_async and sdl audio functions HOT 3
- Bug in SDL_DelayNS() HOT 2
- Game controller support matrix HOT 3
- DisplayModes for Android devices
- ffplay fails to restore window position correctly upon toggling 'maximize'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdl.