Giter Club home page Giter Club logo

Comments (4)

stingly avatar stingly commented on July 18, 2024 2

I am not able to push up a new branch and not sure of the best way to help... I assume that the repository is locked down, which is understandable... my diff is pretty simple:

/addons/LDtk-Importer/LDtk.gd

func new_tilemap(tilemap_data):
	var flip = int(tile["f"])
	var flipX = bool(flip & 1)
	var flipY = bool(flip & 2)
	var grid_coords = pxCoords_to_gridCoords(tile.px, tilemap_data.__gridSize)
        tilemap.set_cellv(grid_coords, tile.t, flipX, flipY)
        return tilemap
 
#converts pixels to grid coordinates.
func pxCoords_to_gridCoords(pixelValues, gridSize):
       var gridY = floor(pixelValues[1] / gridSize)
       var gridX = floor(pixelValues[0] / gridSize)
       return Vector2(gridX, gridY)

Basically it looks like LDtk references the same tile within the "d" attribute multiple times when a rectangle shape is defined. Consequently the tile is overwritten and will only display the last shape in the applied rectangle. I created a grid coord function to take the pixel value instead, which is accurate, and update the tile based on that.

from godot-ldtk-import.

stingly avatar stingly commented on July 18, 2024 1

I've located and fixed the issue - just working up a pull request :)

image

from godot-ldtk-import.

stingly avatar stingly commented on July 18, 2024

I'm also having the exact same issue...

from godot-ldtk-import.

stingly avatar stingly commented on July 18, 2024

Think I've worked out how to actually contribute!

from godot-ldtk-import.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.