Comments (3)
Lecrapouille
commented on July 30, 2024
1
@pimhakkert thanks for your report ! I know I could add more pre-checks to verify if some tools for the building phase are present on the system (scons ...).
One guy reported an issue with Scons I guess pyhron's scons vs installed Scons see
#9. You can try change this line.
https://github.com/Lecrapouille/gdcef/blob/godot-4.x/addons/gdcef/build.py#L49-L52
and maybe update your scons version
And hack to know: removing the gdcef/addons/gdcef/thirdparty/ folders force, the buid to be redone from all steps and can fix issues if something odd happened during the initial failed step.
from gdcef.
pimhakkert
commented on July 30, 2024
Had a look at the error again after a good night's sleep and I noticed I didn't install git on my windows.
Unfortunately after doing a fresh redownload of the extension I'm still bogged down:
C:\Users\PTHak\Documents\ui-test-7\addons\gdcef>python build.py
←[32m[INFO] Checking cmake version ...←[00m
Microsoft (R) C/C++ Optimizing Compiler Version 19.40.33812 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
win.cc
Microsoft (R) Incremental Linker Version 14.40.33812.0
Copyright (C) Microsoft Corporation. All rights reserved.
/out:win.exe
win.obj
[INFO] MS C++ Compiler OK
[INFO] Clone cpp wrapper for Godot 4.2 into C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\thirdparty\godot-4.2\cpp
Cloning into 'C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\thirdparty\godot-4.2\cpp'...
remote: Enumerating objects: 10755, done.
remote: Counting objects: 100% (2429/2429), done.
remote: Compressing objects: 100% (517/517), done.
remote: Total 10755 (delta 2074), reused 2067 (delta 1873), pack-reused 8326
Receiving objects: 100% (10755/10755), 13.57 MiB | 23.40 MiB/s, done.
Resolving deltas: 100% (6879/6879), done.
[INFO] Compiling Godot C++ API (inside C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\thirdparty\godot-4.2\cpp) ...
scons: Reading SConscript files ...
NameError: name 'BoolVariable' is not defined:
File "C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\thirdparty\godot-4.2\cpp\SConstruct", line 36:
cpp_tool.options(opts, env)
File "C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\thirdparty\godot-4.2\cpp\tools\godotcpp.py", line 325:
tool.options(opts)
File "C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\thirdparty\godot-4.2\cpp\tools\ios.py", line 24:
opts.Add(BoolVariable("ios_simulator", "Target iOS Simulator", False))
Traceback (most recent call last):
File "C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\build.py", line 522, in <module>
compile_godot_cpp()
File "C:\Users\PTHak\Documents\ui-test-7\addons\gdcef\build.py", line 389, in compile_godot_cpp
run(SCONS + ["platform=windows", "target=" + GODOT_CPP_TARGET, "use_static_cpp=no",
File "C:\Users\PTHak\AppData\Local\Programs\Python\Python312\Lib\subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['scons', 'platform=windows', 'target=template_release', 'use_static_cpp=no', '--jobs=12']' returned non-zero exit status 2.
from gdcef.
pimhakkert
commented on July 30, 2024
Managed to fix this as well. @Lecrapouille Please weigh in on what needs to be done for a permanent fix. I don't think it's anything you can fix, but wanted to double check with you.
The fix
Once the build.py script finishes pulling godot-4.2 I exit the script and open the following files under thirdparty/godot-4.2/cpp/tools:
- windows.py
- ios.py
- linux.py
I add from SCons.Variables import BoolVariable to the imports of these files. For some reason importing * does not work and you need to specifically import BoolVariable. I then re-run build.py and it successfully compiles.
from gdcef.
Related Issues (20)
- godot-4 branch: Stopping debug mode in editor often does not close gdcefSubProcess.exe on Windows 11 HOT 6
- audio bus output HOT 6
- No SConstruct file found.
- Need to pass modifiers in all mouse events HOT 1
- error: "Can't open dynamic library: cef_artifacts/libgdcef.dll" when execute a build for windows platform HOT 9
- Android Support HOT 3
- Not able to get jitsi-meet works in the 2D demo HOT 18
- Slow and buggy on some webpages HOT 1
- Communicating data between gdscript <-> browser HOT 4
- Copy/paste in Godot input text makes the application freezing
- CAN i use C# with this addon？ HOT 2
- Support Godot 4.2.2
- Missed key inputs
- Multiple audio streams
- Vulkan issue: Godot shall be in "compatibility" mode instead of "forward+" mode HOT 3
- Error: _register_extension_class_internal: Attempt to register extension class 'GDCef', which appears to be already registered. HOT 4
- Rethink about settings artifacts and exported_artifacts HOT 1
- Feature request: Android exports for VR Quest WebViews HOT 3
- (Co)-Maintainers wanted HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdcef.