kunstmaanlegacy / kunstmaansentrybundle Goto Github PK

In recents commit, you introduced the enabled (and/or the dsn) option.
But if we don't enable the plugin, it still wants to validate the dsn parameter.

The path "kunstmaan_sentry.dsn" cannot contain an empty value, but got null.

If we set :

kunstmaan_sentry:
    enabled: false

You shouldn't try to validate other parameters since it is not enabled.
Or at least, you should allow :

kunstmaan_sentry:
    enabled: false
    dsn: null

Or

kunstmaan_sentry:
    enabled: false
    dsn: ''

Having to define a sentry.dsn parameter is ugly

Is there any reason to use this bundle if monolog has support for sentry: https://github.com/Seldaek/monolog/pull/76/files?

monolog:
    handlers:
        sentry:
            type: raven
            dsn: %sentry.dsn%
            level: error

Instead of doing:

# config.yml
kunstmaan_sentry:
    environments: ['prod', 'stage', 'my_optional_env']

You should be able to just do

# config.yml
kunstmaan_sentry:
    enabled: true

# config_dev.yml
kunstmaan_sentry:
    enabled: false

in EventListener/ExceptionListener.php, line 5

The class Symfony\Component\HttpKernel\Kernel is declared but never used. You should remove the use statement.

<?php
namespace Kunstmaan\SentryBundle\EventListener;

use Kunstmaan\SentryBundle\Raven\Raven;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;

/**
 * ExceptionListener

Posted from SensioLabsInsight

hello
https://github.com/Kunstmaan/KunstmaanSentryBundle/blob/master/EventListener/ExceptionListener.php#L42

The production env. usually is called prod but not always, is possible to remove that condition, maybe checking if is enable from a config flag, there's also the %kernel.debug% variable.

Thanks.

Raven has multiple version, you should require something that is not master https://packagist.org/packages/raven/raven