kunstmaanlegacy / kunstmaansentrybundle Goto Github PK

THIS REPO IS DEPRECATED: replaced by Monolog | The SentryBundle for Symfony2 helps binds the raven-php module into a Symfony2 bundle for easy use with the framework. It will autoload an exception handler into the framework, so that all uncaught errors are sent to a Sentry server.

Home Page: http://bundles.kunstmaan.be

License: MIT License

PHP 100.00%

kunstmaansentrybundle's Introduction

IMPORTANT: We recommend that you no longer use this bundle. Since it's inception Monolog has gotten built in Sentry support. See #18 and https://github.com/Seldaek/monolog/pull/76/files

SentryBundle for Symfony2

This helps binds the raven-php module into a Symfony2 bundle for easy use with the framework. It will autoload an exception handler into the framework, so that all uncaught errors are sent to a Sentry server.

Important: This bundle is heavily inspired by Drew Butler's Airbrake bundle.

Installation requirements

You should be able to get Symfony 2.1 up and running before you can install the KunstmaanAdminBundle.

Installation instructions

Assuming you have installed composer.phar or composer binary:

$ composer require kunstmaan/sentry-bundle

Add the KunstmaanSentryBundle to your AppKernel.php file:

new Kunstmaan\SentryBundle\KunstmaanSentryBundle(),

Multiple environments support

To enable Sentry for a specific environment, add these lines to the config.yml file for the environment (ie. config_prod.yml) :

kunstmaan_sentry:
    enabled: true
    dsn: "http://nnn:[email protected]/1"

Note that Sentry logging is disabled by default.

kunstmaansentrybundle's People

Contributors

Stargazers

Watchers

Forkers

gertvr practo benji07 mprzytulski gromnan tiraeth stepanbokoc jocelyndubois psoders shieldo

kunstmaansentrybundle's Issues

If the bundle is disabled (ie: `enabled: false`), don't validate the dsn parameter

In recents commit, you introduced the enabled (and/or the dsn) option.
But if we don't enable the plugin, it still wants to validate the dsn parameter.

The path "kunstmaan_sentry.dsn" cannot contain an empty value, but got null.

If we set :

kunstmaan_sentry:
    enabled: false

You shouldn't try to validate other parameters since it is not enabled.
Or at least, you should allow :

kunstmaan_sentry:
    enabled: false
    dsn: null

kunstmaan_sentry:
    enabled: false
    dsn: ''

Use DI configuration for everything

Having to define a sentry.dsn parameter is ugly

hardcoded Env: 'prod'

hello
https://github.com/Kunstmaan/KunstmaanSentryBundle/blob/master/EventListener/ExceptionListener.php#L42

The production env. usually is called prod but not always, is possible to remove that condition, maybe checking if is enable from a config flag, there's also the %kernel.debug% variable.

Thanks.

[Insight] Unused use statement should be avoided

in EventListener/ExceptionListener.php, line 5

The class Symfony\Component\HttpKernel\Kernel is declared but never used. You should remove the use statement.

<?php
namespace Kunstmaan\SentryBundle\EventListener;

use Kunstmaan\SentryBundle\Raven\Raven;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;

/**
 * ExceptionListener

Posted from SensioLabsInsight

Change the way to enable multiple environments

Instead of doing:

# config.yml
kunstmaan_sentry:
    environments: ['prod', 'stage', 'my_optional_env']

You should be able to just do

# config.yml
kunstmaan_sentry:
    enabled: true

# config_dev.yml
kunstmaan_sentry:
    enabled: false

Require raven branch/tag

Raven has multiple version, you should require something that is not master https://packagist.org/packages/raven/raven

Sense of this bundle

Is there any reason to use this bundle if monolog has support for sentry: https://github.com/Seldaek/monolog/pull/76/files?

monolog:
    handlers:
        sentry:
            type: raven
            dsn: %sentry.dsn%
            level: error