kooliahmd / syliuscatalogpromotionplugin Goto Github PK

View Code? Open in Web Editor NEW

10.0 2.0 5.0 406 KB

Sylius plugin for catalog promotion

License: MIT License

PHP 97.12% HTML 2.88%

sylius plugin promotion

syliuscatalogpromotionplugin's People

Contributors

Stargazers

Watchers

Forkers

aimeric zubis editag julienbock acseo

syliuscatalogpromotionplugin's Issues

[Feature] Catalog promotion based on user group

Thanks for this plugin, it's really helpful to show promotions on the catalog.

It might be interesting to display a catalog promotion for a group of users when they are authenticated. In the same way that it is possible to make a promotion on the cart for a user group.

What do you think about this feature?

Cannot save catalogue promotion on Sylius 1.0.9

Symfony\Component\Debug\Exception\FatalThrowableError:
Type error: Return value of SnakeTn\CatalogPromotion\Entity\PromotionRule::getType() must be of the type string, null returned

  at vendor/snake-tn/catalog-promotion-plugin/src/Entity/PromotionRule.php:54
  at SnakeTn\CatalogPromotion\Entity\PromotionRule->getType()
     (vendor/symfony/symfony/src/Symfony/Component/PropertyAccess/PropertyAccessor.php:473)
  at Symfony\Component\PropertyAccess\PropertyAccessor->readProperty(array(object(PromotionRule)), 'type')
     (vendor/symfony/symfony/src/Symfony/Component/PropertyAccess/PropertyAccessor.php:396)
  at Symfony\Component\PropertyAccess\PropertyAccessor->readPropertiesUntil(array(object(PromotionRule)), object(PropertyPath), 1, true)
     (vendor/symfony/symfony/src/Symfony/Component/PropertyAccess/PropertyAccessor.php:165)
  at Symfony\Component\PropertyAccess\PropertyAccessor->getValue(object(PromotionRule), object(PropertyPath))
     (vendor/symfony/symfony/src/Symfony/Component/Form/Extension/Core/DataMapper/PropertyPathMapper.php:84)
  at Symfony\Component\Form\Extension\Core\DataMapper\PropertyPathMapper->mapFormsToData(object(RecursiveIteratorIterator), object(PromotionRule))
     (vendor/symfony/symfony/src/Symfony/Component/Form/Form.php:628)
  at Symfony\Component\Form\Form->submit(array(), true)
     (vendor/symfony/symfony/src/Symfony/Component/Form/Form.php:572)
  at Symfony\Component\Form\Form->submit(array(array('type' => 'has_taxon', 'configuration' => array('taxons' => 'mugs'))), true)
     (vendor/symfony/symfony/src/Symfony/Component/Form/Form.php:572)
  at Symfony\Component\Form\Form->submit(array('rules' => array(array('type' => 'has_taxon', 'configuration' => array('taxons' => 'mugs'))), 'actions' => array(array('type' => 'percentage_discount', 'configuration' => array('percentage' => '10')))), true)
     (vendor/sylius/sylius/src/Sylius/Bundle/ResourceBundle/Form/Extension/HttpFoundation/HttpFoundationRequestHandler.php:109)
  at Sylius\Bundle\ResourceBundle\Form\Extension\HttpFoundation\HttpFoundationRequestHandler->handleRequest(object(Form), object(Request))
     (vendor/symfony/symfony/src/Symfony/Component/Form/Form.php:498)
  at Symfony\Component\Form\Form->handleRequest(object(Request))
     (vendor/sylius/sylius/src/Sylius/Bundle/ResourceBundle/Controller/ResourceController.php:328)
  at Sylius\Bundle\ResourceBundle\Controller\ResourceController->updateAction(object(Request))
     (vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:151)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
     (vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:68)
  at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
     (vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:202)
  at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
     (web/app_dev.php:42)
  at require('/home/gabiudrescu/PhpstormProjects/SyliusStandard/web/app_dev.php')
     (vendor/symfony/symfony/src/Symfony/Bundle/WebServerBundle/Resources/router.php:42)

Cannot save catalogue promotion on Sylius

RFC: how is this interacting with the cart promotions?

how are these promotions interact with the ones from cart?
have you considered creating exclusive catalog promotions, that make products ineligible for cart promotions? and vice-versa: if a product is in a cart promotion, exclude from catalogue promotions?

Inform the admin operator about the selling price

Initially posted here: Sylius/Sylius#7977 (comment)

If you setup a catalogue campaign for a specific product, if you open the product in two different tabs, one in admin view and one in shop view, you'll see it with two prices.

It is hard to understand why the selling price on the website differs the one in admin, especially for a low experience admin operator.

Hence, I propose that the CatalogPromotionPrice to displayed differently in the admin product view / edit page. So that the operator understands why the price is different.

The command is not doing anything

https://github.com/Snake-Tn/SyliusCatalogPromotionPlugin/blob/master/src/Command/PromotionPublishCommand.php#L31

if this line is commented, when run, the command is doing nothing.

once again, to make sure I understand: the purpose of this command is to precalculate all the prices in a CLI environment?

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.