Giter Club home page Giter Club logo

Comments (6)

kooliahmd avatar kooliahmd commented on June 12, 2024

Yes, It's supposed to pre-calculate all the prices according to the rules/action already created.
This command is useful if the calculation of promotion price is heavy and going to slow down the front-end time response.

I didn't test this plugin on a big number of products/promotions, But if there will be a performance issue, My plan is to create a configuration, So we can chose between on-the-fly calculation mode (good for small website) or pre-calculation mode (good for large traffic/data website).

An in progress subject..

from syliuscatalogpromotionplugin.

gabiudrescu avatar gabiudrescu commented on June 12, 2024

can you point me to the logic of the on-the-fly calculation mode? is it when the promotion is saved or when the product listing is rendered?

from syliuscatalogpromotionplugin.

kooliahmd avatar kooliahmd commented on June 12, 2024

When the product variant price is invoked for a given channel [most accurate definition].
It can be invoked in order to be rendered or used for any other propose like calculating the total of an order.

from syliuscatalogpromotionplugin.

ulrikkold avatar ulrikkold commented on June 12, 2024

I installed this plugin in Sylius 1.2 but with restricted success: I haven't got any console command to execute. I even uncommented the mentioned line in PromotionPublishCommand. What am I missing here? (Yes, I also tried cache:clear but with the same result...)

from syliuscatalogpromotionplugin.

kooliahmd avatar kooliahmd commented on June 12, 2024

That's because there is no command to execute. Promotions are calculated every time on demand. As I mentioned on early comment of this thread, I was planing to index promotions prices using a cron style if users complain about performance degradation due to promotion processing.
But until now, it seems working fine and no need for this cmd.

from syliuscatalogpromotionplugin.

ulrikkold avatar ulrikkold commented on June 12, 2024

Thanks for enlightening me. It makes sense, then.

from syliuscatalogpromotionplugin.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.