klei / ng-dependencies Goto Github PK

Analyze javascript code using esprima and return a list of objects representing the angular module dependencies in the code.

JavaScript 100.00%

ng-dependencies's People

Contributors

Stargazers

Watchers

Forkers

blai petebacondarwin mgcrea denyskarpenko tannerlinsley milanlempera randombk hgwood pioug jstans siir visaruruqi wafo pedromartos artofcontext

ng-dependencies's Issues

window.angular.module("foo") not understood.

Thanks for the great work on this plugin.

angular.module("foo"); syntax works great.

window.angular.module("foo"); syntax does not work.

I couldn't find any documentation on the fact so I ran your tests with window in front. Here are the tests:

   it('should capture simple module declaration with window', function () {
    var source = 'window.angular.module("test", []);';
    var deps = {
      dependencies: ['ng'],
      modules: {
        'test': []
      }
    };
    lookup(source).should.eql(deps);
  });

  it('should capture the module dependencies with window', function () {
    var source = 'window.angular.module("test", ["one"]);';
    var deps = {
      dependencies: ['ng', 'one'],
      modules: {
        'test': ['one']
      }
    };
    lookup(source).should.eql(deps);
  });

    it('should capture module dependencies at root level with window', function () {
    var source = 'window.angular.module("test");\nwindow.angular.module("another").controller("Ctrl", ["$scope", function ($scope) {}]);';
    var deps = {
      dependencies: ['ng', 'test', 'another'],
      modules: {}
    };
    lookup(source).should.eql(deps);
  });

All three tests failed. (Can give output if desired)

Is it possible to get this functionality added? How hard is it? I did a quick check on the code and it looks like the isAngularModuleStatement just needs to be changed. I might attempt a pull request.

Sugar dep breaks 6to5!

It breaks on the require of gulp-angular-filesort:

TypeError: Object 0 has no method 'call'
    at /Users/[...]/node_modules/gulp-angular-filesort/node_modules/ng-dependencies/node_modules/sugar/release/sugar-full.development.js:6126:12

Related issue on klei/gulp-angular-filesort#20

It looks like sugar breaks 6to5! Overriding prototypes is never a good idea!

TypeError: Object 0 has no method 'call'
    at /Users/olivier/Projects/ng-tools/gulp-ng-channels/node_modules/gulp-angular-filesort/node_modules/ng-dependencies/node_modules/sugar/release/sugar-full.development.js:6126:12
    at Array.forEach (native)
    at extend.keys (/Users/olivier/Projects/ng-tools/gulp-ng-channels/node_modules/gulp-angular-filesort/node_modules/ng-dependencies/node_modules/sugar/release/sugar-full.development.js:6125:12)
    at /Users/olivier/Projects/ng-tools/gulp-ng-channels/node_modules/gulp-angular-filesort/node_modules/ng-dependencies/node_modules/sugar/release/sugar-full.development.js:179:25
    at Array.map (native)
    at Array.<anonymous> (/Users/olivier/Projects/ng-tools/gulp-ng-channels/node_modules/gulp-angular-filesort/node_modules/ng-dependencies/node_modules/sugar/release/sugar-full.development.js:180:23)
    at Object.<anonymous> (/Users/olivier/Projects/ng-tools/gulp-ng-channels/node_modules/gulp-6to5/node_modules/6to5-core/lib/6to5/traverse/scope.js:40:86)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Users/olivier/Projects/ng-tools/gulp-ng-channels/node_modules/gulp-6to5/node_modules/6to5-core/lib/6to5/traverse/index.js:7:16)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)

findDependencies ends with Unexpected token error if file contains import keyword

You can reproduce error with this test

  it('should ignore import in source', function () {
    var source = 'import angular from "angular";\n' +
        'angular.module("test", []);';

    var deps = {
      dependencies: ['ng'],
      modules: {
        'test': []
      }
    };
    lookup(source).should.eql(deps);
  });

result is Unexpected token error from esprima.

Esprima support ES6 modules, but you must use option sourceType in parse method options.

esprima.parse(source, {sourceType: "module"})

I can send pull request with fix (simply add this option to esprima.parse, or make it configurable by findDependencies options), and import will be ignored - but is it intended behavior?

Does not work with output of ng-classify

(function () {
    var App;
    App = (function () {
        function App() {
            return ['dep1', 'dep2'];
        }
        return App;
    })();
    angular.module('app', new App());
}).call(this);

breaks on https://github.com/klei/ng-dependencies/blob/master/index.js#L32

The above file is the result of ng-classify followed by coffee -> js on this

class App extends App
   constructor: ->
      return [ 'dep1', 'dep2' ]

klei / ng-dependencies Goto Github PK

ng-dependencies's People

Contributors

Stargazers

Watchers

Forkers

ng-dependencies's Issues

window.angular.module("foo") not understood.

Sugar dep breaks 6to5!

findDependencies ends with Unexpected token error if file contains import keyword

Does not work with output of ng-classify

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent