Giter Club home page Giter Club logo

Comments (4)

joakimbeng avatar joakimbeng commented on July 24, 2024

It probably is possible, but why do you actually do this?

Why not just drop the window.?

from ng-dependencies.

SyntaxRules avatar SyntaxRules commented on July 24, 2024

I was working with someone troubleshooting a problem they were having with dependencies. Turned out to be this window..

I asked the same question and they said visual studio doesn't like it when they do just angular.module... so they write window.angular.module.... I'll happily drop the window. for myself. Just looking to be a good contributor and add in the problem use case I found.

from ng-dependencies.

blai avatar blai commented on July 24, 2024

Adding support for window.angular.module would increase the processing time for everybody else who just use angular.module. That's because now we need to look for two patterns instead of one. My suggestion for your case is to wrap your angular code in IIFE, like so:

(function (angular) {
    angular.module(...)
    ...
})(window.angular);

from ng-dependencies.

joakimbeng avatar joakimbeng commented on July 24, 2024

I'm with @blai on this. Closing.

from ng-dependencies.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.