Bug: PR_ID references github issues about cdk-notifier HOT 5 CLOSED

We are experiencing the same issue. We use cdk-notifier during Circle CI build.

!/bin/bash -eo pipefail
if [[ -n "$CIRCLE_PULL_REQUEST" ]]; then
  curl -L "https://github.com/karlderkaefer/cdk-notifier/releases/latest/download/cdk-notifier_$(uname)_amd64.gz" -o cdk-notifier.gz
  gunzip cdk-notifier.gz && chmod +x cdk-notifier && rm -rf cdk-notifier.gz
  sudo mv cdk-notifier /usr/local/bin/cdk-notifier
  cdk-notifier --version
  cdk-notifier -t $PR_COMMENT_TAG -l $CDK_LOG_FILE
fi

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 8262k  100 8262k    0     0  40.1M      0 --:--:-- --:--:-- --:--:--  118M
^@^@cdk-notifier version 2.4.2
FATA[0000] GET https://api.github.com/repos/<ORG>/<REPO>/issues/51/comments?per_page=100: 404 Not Found [] 

Exited with code exit status 1
CircleCI received exit code 1

from cdk-notifier.

Apologies, above was my issue. I supplied an incorrect Github token that did not have access to the correct repository.

from cdk-notifier.

thanks for report, sorry the delayed answer, somehow I do not get notified on new issues. I was not able to reproduce it locally. However github treats pull requests as a special kind of issue, and the Issues API endpoint is used for actions on both issues and pull requests. From what I have read, issues can not have the same id as the pull request in stackoverflow So it's more likely that you somehow used the issue id instead of pr id. So github will redirect to either /issues or /pulls depending on the id. can you try a test from your machine?

export REPO_NAME=your-repo
export REPO_OWNER=your-owner
export PR_ID=71
export GITHUB_TOKEN=***
cdk-notifier -l data/cdk-diff1.log --tag-id small

anyhow I will double-check if there are any API changes and also gonna update github client #71

from cdk-notifier.

@matthias-pichler-shopstory can you describe how you get the --pull-request-id? in github actions there are several ways to get the pull request id

from cdk-notifier.

PR #98 was merged closing this issue, I could not reproduce. please make sure the PR ID can be found and is valid. Feel free to open reopen the issue and provide more details, from my understanding it is not possible that a PR can have same ID as an Github Issue

from cdk-notifier.