Hi, running the command cdk diff --profile

Include the IAM Stament Changes as part of the message posted to Github about cdk-notifier HOT 3 CLOSED

karlderkaefer commented on June 3, 2024

Include the IAM Stament Changes as part of the message posted to Github

from cdk-notifier.

Comments (3)

karlderkaefer commented on June 3, 2024

Just to understand, so you would expect, if there are only IAM Statement Changes they should be also visible on diff on PR? Could on clarify on what inputs (logs) you would expect which output (content of comment)?
The best way is to start adding a test

cdk-notifier/transform/transformer_test.go

Lines 8 to 12 in a3c721a

 func TestLogTransformer_ReadFile(t *testing.T) { 

 transformer := &LogTransformer{ 

 Logfile: "../data/cdk-diff1.log", 

 } 

 err := transformer.readFile()

you can add an example log to data folder. And then check towards expected output.

from cdk-notifier.

karlderkaefer commented on June 3, 2024

actually it should post the comment if there is any IAM Statement Change string in log

cdk-notifier/provider/api.go

Lines 50 to 53 in a3c721a

 func diffHasChanges(log string) bool { 

 regex := regexp.MustCompile(`(?m)(Policy Changes|Resources\n|Statement Changes)`) 

 return regex.MatchString(log) 

 }

from cdk-notifier.

karlderkaefer commented on June 3, 2024

closing because no response

from cdk-notifier.

Related Issues (19)

Bitbucket Workspace access token HOT 3
add an overview section for number of differences and number of replaces HOT 1
Supress service types in overview section HOT 6
extend overview section with list of changed service types HOT 6
add job link to header to open ci job logs HOT 1
Dependency Dashboard
Bitbucket Support HOT 3
Gitlab support HOT 9
Suggestion/Issue IAM Statement Changes HOT 1
[Enhancement] No CI system / local output option HOT 7
Delete comments is not enabled by default HOT 1
Pipeline is not building for forks HOT 1
multi stack support
Feature request: Include a <details> tag around the comment body so it's foldable HOT 5
panic: runtime error HOT 3
Bug: PR_ID references github issues HOT 5
missing gc_lib on ubuntu 20 HOT 1
Cannot comment on a bitbucket pull request HOT 9

Include the IAM Stament Changes as part of the message posted to Github about cdk-notifier HOT 3 CLOSED

Comments (3)

Related Issues (19)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func TestLogTransformer_ReadFile(t *testing.T) {
	transformer := &LogTransformer{
	Logfile: "../data/cdk-diff1.log",
	}
	err := transformer.readFile()

	func diffHasChanges(log string) bool {
	regex := regexp.MustCompile(`(?m)(Policy Changes\|Resources\n\|Statement Changes)`)
	return regex.MatchString(log)
	}