Comments (6)
@JohannesKonings It kind of makes sense, but not sure if everybody wants to enable this. Also if we add more custom reporting features like that, the cli argument lsit will be bloated. There are already too many args. In theory I would need to split them by e.g. CI.
So instead of adding more reporting features to existing code, I would simply give the user the options to create templates for them selves with --report-template-file
where users can provide a go template as string or file. If we want, we still can provide default go templates as string const through cdk notifier. An example cli args would look like
--report-template [default|summary|extended]
what do you think?
from cdk-notifier.
@karlderkaefer thanks, works great 👍
from cdk-notifier.
the link you posted for aws cdk diff as json looks interesting, we can iterate over this again when json for cdk diff is available
from cdk-notifier.
Sounds great. That way will be more flexible.
from cdk-notifier.
🎉 This issue has been resolved in version 2.9.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from cdk-notifier.
@JohannesKonings feature is now available with --template extendedWithResources
https://github.com/karlderkaefer/cdk-notifier/blob/main/README.md#custom-comment-template
and users can define own templates if they want. let me know if it works as expected
from cdk-notifier.
Related Issues (20)
- Bitbucket Workspace access token HOT 3
- add an overview section for number of differences and number of replaces HOT 1
- Supress service types in overview section HOT 6
- add job link to header to open ci job logs HOT 1
- Arm64 docker image are not working, because they contain a x64 binary HOT 4
- cdk-notifier produces github url when CI configuration is for self hosted Gitlab HOT 4
- Dependency Dashboard
- Bitbucket Support HOT 3
- Gitlab support HOT 9
- Suggestion/Issue IAM Statement Changes HOT 1
- [Enhancement] No CI system / local output option HOT 7
- Delete comments is not enabled by default HOT 1
- Pipeline is not building for forks HOT 1
- Include the IAM Stament Changes as part of the message posted to Github HOT 3
- Feature request: Include a <details> tag around the comment body so it's foldable HOT 5
- panic: runtime error HOT 3
- Bug: PR_ID references github issues HOT 5
- missing gc_lib on ubuntu 20 HOT 1
- Cannot comment on a bitbucket pull request HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cdk-notifier.