Giter Club home page Giter Club logo

Comments (6)

karlderkaefer avatar karlderkaefer commented on June 3, 2024 1

@JohannesKonings It kind of makes sense, but not sure if everybody wants to enable this. Also if we add more custom reporting features like that, the cli argument lsit will be bloated. There are already too many args. In theory I would need to split them by e.g. CI.
So instead of adding more reporting features to existing code, I would simply give the user the options to create templates for them selves with --report-template-file where users can provide a go template as string or file. If we want, we still can provide default go templates as string const through cdk notifier. An example cli args would look like

--report-template [default|summary|extended]

what do you think?

from cdk-notifier.

JohannesKonings avatar JohannesKonings commented on June 3, 2024 1

@karlderkaefer thanks, works great 👍

from cdk-notifier.

karlderkaefer avatar karlderkaefer commented on June 3, 2024 1

the link you posted for aws cdk diff as json looks interesting, we can iterate over this again when json for cdk diff is available

from cdk-notifier.

JohannesKonings avatar JohannesKonings commented on June 3, 2024

Sounds great. That way will be more flexible.

from cdk-notifier.

karlderkaefer avatar karlderkaefer commented on June 3, 2024

🎉 This issue has been resolved in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from cdk-notifier.

karlderkaefer avatar karlderkaefer commented on June 3, 2024

@JohannesKonings feature is now available with --template extendedWithResources https://github.com/karlderkaefer/cdk-notifier/blob/main/README.md#custom-comment-template

and users can define own templates if they want. let me know if it works as expected

from cdk-notifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.