Giter Club home page Giter Club logo

Comments (3)

juj avatar juj commented on September 27, 2024

Do you have a recommendation where to locate it better? I am hesitant to adding new directories in the source tree and the Math/ directory already contains all the logging functions as well (MathLog.h/.cpp) and callstack is very closely related to logging.

from mathgeolib.

LogicalError avatar LogicalError commented on September 27, 2024

I would probably put it into a separate directory called logging, it doesn't have anything (directly) to do with math ...
... why are you hesitant to add a new directory? is there a downside? ;)

from mathgeolib.

juj avatar juj commented on September 27, 2024

Having more directories means having more things to have to remember ("Did I have to #include "Math/Foo.h" or #include "Logging/Foo.h" or something else?"), and people have requested to not use absolute include directories so that users don't need to add multiple include directives i.e. -IMathGeoLib/ + -IMathGeoLib/Math + -IMathGeoLib/Geometry/. This means that the include directories in code have relative paths like #include "../../Math/Foo.h" and it looks a bit ugly.

I don't want to change existing code file locations, because that will definitely break code for all users if they need to change include files around. So it's simplest to keep the directory structure that currently exists, and not add new ones (unless there would be a large bulk of files to add in a new directory, that'd make organization much clearer).

from mathgeolib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.