Same grep version on CentOS 6.x and 7.x, same error on both.

What is the required grep version?

$ git commit
.git/hooks/prepare-commit-msg: line 43: conditional binary operator expected
.git/hooks/prepare-commit-msg: line 43: syntax error near `=~'
.git/hooks/prepare-commit-msg: line 43: `  if [[ "${IGNORED[*]}" =~ "${filename}" || "${IGNORED[*]}" =~ "${extension}" ]]; then'

$ cd ../commit-comments/
$ git log | head -n 1
commit a916600e8cc2b0cb0f6da2533d616da3ddca5f68

$ /bin/bash --version
GNU bash, version 3.1.20(4)-release (i686-pc-msys)
Copyright (C) 2005 Free Software Foundation, Inc.

Running

#!/bin/bash
ADDED_FILES=( $(git ls-files) )
echo $ADDED_FILES
echo '************'
for i in ${!ADDED_FILES[@]}; do
  file_path=${ADDED_FILES["$i"]}
  filename=$( basename "$file_path" )
  extension="${filename##*.}"
  echo $file_path
  echo $filename
  echo $extension
  if [[ "${IGNORED[*]}" =~ "${filename}" || "${IGNORED[*]}" =~ "${extension}" ]]; then
    # File should not be read - remove
    unset ADDED_FILES["$i"]
  fi
done

gives

$ . test.sh
.gitignore
************
sh.exe": ./test.sh: line 12: conditional binary operator expected
sh.exe": ./test.sh: line 12: syntax error near `=~'
sh.exe": ./test.sh: line 12: `  if [[ "${IGNORED[*]}" =~ "${filename}" || "${IGNORED[*]}" =~ "${extension}" ]]; then'

Assuming that the comments are included in the committed code (and not just the commit comment), perhaps you could use the more accurate comment to code mapping for browsing and search purposes?

When using git add --patch commit-comments from outside the current patch are added to the commit message and all commit tags are removed, not just those from the current patch.

For example, say I have the following diff of a file in my repo:

 #! /usr/bin/env python

+#@commit greeting alice
+print("Hi Alice")
+
 print("Hello World")
+
+#@commit say goodbye
+print("Goodbye World")

I add the first hunk using git add --patch, but ignore the second hunk.
The commit message I get is:

 - [test.py#3] greeting alice
 - [test.py#8] say goodbye

And after removing the commit-comments the file looks like:

#! /usr/bin/env python

print("Hi Alice")

print("Hello World")

print("Goodbye World")

The correct behaviour should be for the commit message to be:

 - [test.py#3] greeting alice

And the file to be:

#! /usr/bin/env python

print("Hi Alice")

print("Hello World")

#@commit say goodbye
print("Goodbye World")

(Loving the tool by-the-way!)

I am very fond of this functionality as it always seemed to me like i actually forget the details of the change during commit. And as its implemented right now using bash scripts, i doubt it will be easy to port to Windows systems. That would have been really great if it supported both systems. But i would still like to know if something like that is in the pipeline?

Hi Jacob,

I just tried your scripts and wanted to let you know that you get the following error message in case you do not have pcregrep installed (on commit obviously):

.git/hooks/post-commit: line 15: pcregrep: command not found

Maybe I'll make a pull request with a patch later, but wanted to anyway already document to error.

Regards

Among other weirdness I encountered, it appears multiline commit messages aren't supported, or I used the wrong syntax. Would be a great feature to have, as I instinctively wrap lines to 80 characters. (I realize how stupid this sounds given the fact that the point of these hooks are to remove the comments before committing.)

The post-commit hook gets me this:

sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]

git grep --cached should work good enough.