Giter Club home page Giter Club logo

Comments (6)

jryio avatar jryio commented on June 6, 2024

Thank you very much!

Would you mind letting me know which Operating System you're running and which version as well. Also Bash version would be very helpful too.

from commit-comments.

fbartels avatar fbartels commented on June 6, 2024

Sure, I've observed this on Ubuntu 14.04, bash is "GNU bash, Version 4.3.11(1)-release (x86_64-pc-linux-gnu)"

from commit-comments.

jryio avatar jryio commented on June 6, 2024

I will add a similar conditional to the post-commit hook as is in the prepare-commit-msg hook to check if pcregrep is present. I apologize for leaving out the portability check.

Additionally, I did look up all packages which ship with Ubuntu 14.04 - and pcregrep is not included. I apologize for the oversight. Fix coming immediately.

from commit-comments.

jryio avatar jryio commented on June 6, 2024

If you could checkout PR #7 and verify that GNU grep is being used in the post-commit hook that would be much appreciated!

🚀

from commit-comments.

fbartels avatar fbartels commented on June 6, 2024

Hi, thanks for the fast fix. I've checked out your branch and do not see the error message anymore.

Yes, I have seen that the package is also available on Ubuntu, but then I would have to install everywhere. Centrally managed hooks are quite easy, synced packages lists not much so ;-).

from commit-comments.

jryio avatar jryio commented on June 6, 2024

🎉

from commit-comments.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.