Hi, I saw you're using own uint, uint64 types. What do you think to switch to uint

Use standard types about joltphysics HOT 2 CLOSED

amerkoleci commented on May 26, 2024

Use standard types

from joltphysics.

Comments (2)

amerkoleci commented on May 26, 2024 1

It was just of using standard types on global scope and avoid JPH::uint, etc.

Thanks for clarification

from joltphysics.

jrouwe commented on May 26, 2024

These types are just aliases for the std equivalents (and the typedefs are inside the JPH namespace so should not leak out to the user of the library):

JoltPhysics/Jolt/Core/Core.h

Lines 426 to 430 in 1718c93

 using uint = unsigned int; 

 using uint8 = std::uint8_t; 

 using uint16 = std::uint16_t; 

 using uint32 = std::uint32_t; 

 using uint64 = std::uint64_t;

So you should be able to use them interchangeably with std::uint32_t etc.

What would be the benefit of this change? (I can see a clear downside, namely that it would break all my carefully lined out class headers)

from joltphysics.

Related Issues (20)

Building with clang using ninja on windows HOT 5
SixDOFConstraint needs to be able to have non-symmetrical rotation limits
Toggling manifold reduction doesn't result in any contact callbacks HOT 2
Mouse input is too sensitive when running samples on a remote machine over Parsec HOT 5
[Feature Request] Soft-soft collisions and self-collisions HOT 3
MeshShape: SaveBinaryState and sRestoreFromBinaryState dont work like intended HOT 2
Performance regression with 9d63f5a2d1b9e426a54dce6c8979e22ff6004eba HOT 9
[Feature Request] Compute gyroscopic forces HOT 5
Speculative contact distance affects sensors HOT 1
Core.h wasn't updated to reflect on the new version HOT 1
Jolt Complilation Fails on Manjaro Linux HOT 2
Incorrect moment of inertia for capsule HOT 4
Soft bodies assert when colliding with ragdolls HOT 4
Should BodyInterface::MoveKinematic check for SucceededAndIsInBroadPhase ? HOT 2
Weird angular impulse behaviour (rotational inertia)
The simulation runs too fast HOT 2
Build fails using default CMakeLists HOT 4
Soft bodies elicit a collision response from sensors HOT 1
Collision with degenerate line triangle HOT 1

Use standard types about joltphysics HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	using uint = unsigned int;
	using uint8 = std::uint8_t;
	using uint16 = std::uint16_t;
	using uint32 = std::uint32_t;
	using uint64 = std::uint64_t;