Building with clang using ninja on windows about joltphysics HOT 5 CLOSED

I hit the same issue as @Hatrickek (apparently 7 hours after). The workaround is good to get buildling/running, although it may be that skipping that if block means some of the build configurations won't be set up right. I have been using cmake/ninja/clang for builds.

from joltphysics.

I would probably advise just replacing that whole thing with if (MSVC), which will be truthy whenever the compiler defines _MSC_VER, which would cover Microsoft's own cl as well as clang-cl, but none of the compilers adhering to the GCC-like interface, like MinGW-based compilers or (in this case) native clang.

Then this could probably just be an else(), since any other supported compiler is likely to emulate the GCC-like interface anyway, including native clang on Windows.

from joltphysics.

I like @mihe's solution better. I've created #767 and it looks like it passes all builds. Can you let me know if this works for ninja too? (I don't use it)

from joltphysics.

I can confirm that @mihe's solution works for my cmake/clang/ninja setup.

from joltphysics.

It indeed works thanks 🙂

from joltphysics.