Giter Club home page Giter Club logo

gatsby-s3-action's Issues

node16 warning

Current use of this action produces a warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: jonelantha/gatsby-s3-action@v1

It needs to be upgraded to use the node16 runtime

Only upload changed files

I've a site which builds 6000+ pages. Is it possible to detect which pages have been modified and only upload those? Current GitHub action time is about 5 minutes to upload anything. Any way to optimise this would be greatly appreciated

Set content-type in S3 for html files

Hello @jonelantha,
thanks for making my deployment process so easy!

I am using the package now for quite some time. Unfortunately, I encountered a strange behavior in the last few dates. AWS is setting the wrong content-type for my HTML files in S3. index.html has now the type binary/octet-stream. It should be text/html. Is it possible to set the content-type somewhere? Was there any change that could cause that behavior? I could not find anything in the commits.

Thanks,
Markus

Client route 404 flash

Hi @jonelantha - thanks for creating this action - really useful work.

Wondering if you can help me with an issue;

I am deploying my gatsby site to s3 using your action. I have a cloudfront distribution set up infront of the s3 bucket and invalidation from your action is working well. I have the whole thing behind a custom route53 domain.

I have gatsby set up with many client routes like so;

Route: mydomain.com/index.html
Route: mydomain.com/404.html
Route: mydomain.com/app
ClientRoute: mydomain.com/app/dashboard
ClientRoute: mydomain.com/app/users
More client routes ClientRoute: mydomain.com/app/<etc... >/<etc... >

The app route bootstraps the client app that handles the client route navigation.

I am having an issue where when I navigate from / to /app/dashboard after a successful login I get a flash of the 404 page before the client route kicks in and displays the correct page.

This also occurs on a hard refresh to a client route.

This issue is the same as the one described here: https://stackoverflow.com/a/52770491/849779

I have tried to fix this using s3 redirects as described on stack overflow.

I have also set up a Lambda@edge function as you described in your page here: https://blog.elantha.com/cloudfront-index-lambda/

Unfortunately nothing seems to work. Wondering if you could perhaps share any other resources that could help me solve this issue?

Thanks in advance.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.