jonelantha / gatsby-s3-action Goto Github PK

Hello @jonelantha,
thanks for making my deployment process so easy!

I am using the package now for quite some time. Unfortunately, I encountered a strange behavior in the last few dates. AWS is setting the wrong content-type for my HTML files in S3. index.html has now the type binary/octet-stream. It should be text/html. Is it possible to set the content-type somewhere? Was there any change that could cause that behavior? I could not find anything in the commits.

Thanks,
Markus

Current use of this action produces a warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: jonelantha/gatsby-s3-action@v1

It needs to be upgraded to use the node16 runtime

It would be nice to have the option to set a custom ./public directory incase the users gatsby project is not in the root of the repo.

currently I get this error when running the deploy script
The user-provided path ./public/ does not exist.

Hi @jonelantha,
Thanks for the amazing work.

I have an issue with emptying the bucket as there are different places deploying into the same bucket.

is there's a way to delete only gatsby files instead of everything?

Kind regards,
Hashem

I've a site which builds 6000+ pages. Is it possible to detect which pages have been modified and only upload those? Current GitHub action time is about 5 minutes to upload anything. Any way to optimise this would be greatly appreciated

Hi @jonelantha - thanks for creating this action - really useful work.

Wondering if you can help me with an issue;

I am deploying my gatsby site to s3 using your action. I have a cloudfront distribution set up infront of the s3 bucket and invalidation from your action is working well. I have the whole thing behind a custom route53 domain.

I have gatsby set up with many client routes like so;

Route: mydomain.com/index.html
Route: mydomain.com/404.html
Route: mydomain.com/app
ClientRoute: mydomain.com/app/dashboard
ClientRoute: mydomain.com/app/users
More client routes ClientRoute: mydomain.com/app/<etc... >/<etc... >

The app route bootstraps the client app that handles the client route navigation.

I am having an issue where when I navigate from / to /app/dashboard after a successful login I get a flash of the 404 page before the client route kicks in and displays the correct page.

This also occurs on a hard refresh to a client route.

This issue is the same as the one described here: https://stackoverflow.com/a/52770491/849779

I have tried to fix this using s3 redirects as described on stack overflow.

I have also set up a Lambda@edge function as you described in your page here: https://blog.elantha.com/cloudfront-index-lambda/

Unfortunately nothing seems to work. Wondering if you could perhaps share any other resources that could help me solve this issue?

Thanks in advance.