johnezang / jsonkit Goto Github PK

It may be a user error, but I am unable serialize a dictionary containing an MSMutableData object.

When attempting to do so, I get

Error Domain=JKErrorDomain Code=-1 "Unable to serialize object class NSConcreteMutableData." UserInfo=0x4c31b50 {NSLocalizedDescription=Unable to serialize object class NSConcreteMutableData.}

I'm using JSONKit to parse GitHub news feeds, and it is currently crashing on this JSON:

{
    public: true
    actor: "mojombo"
    repository: {
        integrate_branch: "staging"
        master_branch: "master"
        open_issues: 313
        has_downloads: false
        description: "The missing package manager for OS X."
        private: false
        fork: false
        owner: "mxcl"
        url: "https://github.com/mxcl/homebrew"
        pushed_at: "2011/06/27 17:08:07 -0700"
        created_at: "2009/05/20 12:38:37 -0700"
        homepage: "http://mxcl.github.com/homebrew"
        size: 23248
        has_wiki: true
        forks: 2328
        language: "Ruby"
        has_issues: true
        name: "homebrew"
    watchers: 5023
    }
    actor_attributes: {
        location: "San Francisco"
        gravatar_id: "25c7c18223fb42a4c6ae1c8db6f50f9b"
        company: "GitHub, Inc."
        email: "[email protected]"
        type: "User"
        blog: "http://tom.preston-werner.com"
        name: "Tom Preston-Werner"
        login: "mojombo"
    }
    created_at: "2011/06/27 18:36:50 -0700"
    payload: {
    }
    type: "ForkEvent"
    url: "https://github.com/mojombo/homebrew"
}

In my code, I'm doing:

NSDictionary *payload = [attributes valueForKey:@"payload"];
NSDictionary *repo = [payload valueForKey:@"repo"];

Because the payload dictionary is empty, the subsequent call to get the repo dictionary throws a divide by zero exception from the modulus operation on line 1009 of JSONKit.m:

  NSUInteger        keyHash = CFHash(aKey), keyEntry = (keyHash % dictionary->capacity), idx = 0UL;

Encoding a dictionary with some NSNumbers gives me a JSON with all values ".17g". I have no idea what it means. Code:

NSMutableDictionary *json = [NSMutableDictionary dictionary];
[json setObject:n2 forKey:@"n2"];
[json setObject:n1 forKey:@"n1"];

NSError *error=nil;
NSString *p=[json JSONStringWithOptions:JKSerializeOptionNone error:&error];
NSLog(@"JSON: %@ %f %f",p,[n1 doubleValue],[n2 doubleValue]);

JSON output: '{"n2":.17g,"n1":.17g}'. No error.

LLVM GCC 4.2 with XCode 4. Debug build, no optimizations.

I'm getting a crash in the _JKDictionaryHashTableEntryForKey function on this line:

NSUInteger        keyHash = CFHash(aKey), keyEntry = (keyHash % dictionary->capacity), idx = 0UL;

I was calling valueForKeyPath: on a dictionary I got out of JSONKit that happened to have no entries. I think it's crashing because it's trying to mod the keyHash with zero.

I browsed through your code and wondered why exactly the caller is responsible to retain the object that is going to be inserted into the array via _JKArray methods.
You're using CFRelease and -autorelease to manage retain counts in those methods, but no CFRetain or -retain. I'm sure there's a reason for that, but I could not figure out what it is.

Please enlighten me :)

best,
Ullrich

Hi,

First of all, thanks a lot for your great work!

Could you please look at that SO question and tell us if those are leaks from JSONKit we are seeing or we are just noobs? :)

Feel free to contact me for more informations.

Vincent.

I'm using JSONKit in a Cocoa application and I started using the gc and realized that JSONKit is not supporting gc.
Is there any workaround or a beta version to enable it?

thanks

JSONKit crashes when parsing the string "{}" with a divide by zero error. The following change has fixed the issue for me:

--- a/Vendor/JSONKit/JSONKit.m
+++ b/Vendor/JSONKit/JSONKit.m
@@ -1005,7 +1005,8 @@ static void _JKDictionaryAddObject(JKDictionary *dictionary, NSUInteger keyHash,

static JKHashTableEntry *_JKDictionaryHashTableEntryForKey(JKDictionary *dictionary, id aKey) {
NSCParameterAssert((dictionary != NULL) && (dictionary->entry != NULL) && (dictionary->count <= dictionary->capacity));

• if(aKey == NULL) { return(NULL); }
• // Guard against a divide by zero here.
• if(aKey == NULL || 0 == dictionary->capacity) { return(NULL); }
  NSUInteger keyHash = CFHash(aKey), keyEntry = (keyHash % dictionary->capacity), idx = 0UL;
  JKHashTableEntry *atEntry = NULL;
  for(idx = 0UL; idx < dictionary->capacity; idx++) {

Get around to adding a stable branch that can be the formal recommend branch for people that want to include JSONKit via a git submodule. The purpose would be to track "production quality and stable" changes to JSONKit inbetween version milestones.

The changes that would land in stable would be conservative, and people should always feel confident in syncing their local stable branch following versions of JSONKit with the latest commits to the stable branch in the github.com repository.

It might make some sense to create stable branches of different versions. This would allow people to "freeze" their projects JSONKit git submodule to a particular version, but still pick up important / critical fixes to that particular version without having to worry about whether changes required to implement new features for later versions interacting in unexpected ways with their app.

Comments from the community are welcome.

Hi,

I can't figure out if this error is on my side or on the JSONKit's side but I get NSAutoreleaseNoPool errors for a whole bunch of objects:

date - appName[305:7e07] *** __NSAutoreleaseNoPool(): Object 0x5c590d0 of class __NSDate autoreleased with no pool in place - just leaking
" " Object 0x5c58f70 of class NSCFString autoreleased with no pool in place - just leaking
" " Object 0x5c57640 of class __NSCFData autoreleased with no pool in place - just leaking
" " Object 0x5c2bc30 of class NSURL autoreleased with no pool in place - just leaking
" " Object 0x5c58520 of class __NSArrayM autoreleased with no pool in place - just leaking
" " Object 0x5c2cad0 of class NSRecursiveLock autoreleased with no pool in place - just leaking
" " Object 0x5838ba0 of class NSPathStore2 autoreleased with no pool in place - just leaking
" " Object 0x584fac0 of class __NSArrayI autoreleased with no pool in place - just leaking
" " Object 0x5b74120 of class JKSerializer autoreleased with no pool in place - just leaking
" " Object 0x5c2cad0 of class NSRecursiveLock autoreleased with no pool in place - just leaking
" " Object 0x5c53f90 of class __NSCFDictionary autoreleased with no pool in place - just leaking
" " Object 0x58501c0 of class NSConcreteMutableData autoreleased with no pool in place - just leaking
" " Object 0x5850f60 of class JSONDecoder autoreleased with no pool in place - just leaking
" " Object 0x5837ee0 of class JKDictionary autoreleased with no pool in place - just leaking
" " Object 0x5c5af80 of class JSONDecoder autoreleased with no pool in place - just leaking

I get about 100 of each type! Anybody else?

Thanks for the help

There is a warning converting CFHashCode to NSUInteger. I tried typecasting, but this craziness is out of my league :)

http://soff.me/4zWE

I'm using LLVM 2 by the way.

Hello, shouldn't JSONKit deserialize a single number ?

Here is the error I get when I provide the single digit 1 to JSONKit:

    NSData *data = [@"1" dataUsingEncoding:NSUTF8StringEncoding];
    id object = [data objectFromJSONDataWithParseOptions:JKParseOptionStrict error:&error];

Can't print the description of a NIL object.
(gdb) po error
Error Domain=JKErrorDomain Code=-1 "Invalid number." UserInfo=0x5b076a0 {JKAtIndexKey=1, JKLineNumberKey=1, NSLocalizedDescription=Invalid number.}

When requesting jsondata from an NSMutableDictionary created by jsonkit, jsonkit will crash. It works fine for non mutable dictionaries.

Process:         someApp [33571]
Path:            /Users/USER/Library/Developer/Xcode/DerivedData/someApp-dzxzpbtokpnlvbfzxrgbssffgdva/Build/Products/Debug/someApp.app/Contents/MacOS/someApp
Identifier:      com.myCompany.someApp
Version:         1.0 (1)
Code Type:       X86-64 (Native)
Parent Process:  launchd [152]

Date/Time:       2011-03-14 11:02:51.272 -0700
OS Version:      Mac OS X 10.7 (11A390)
Report Version:  8

Interval Since Last Report:          349830 sec
Crashes Since Last Report:           1
Per-App Interval Since Last Report:  47732 sec
Per-App Crashes Since Last Report:   1
Anonymous UUID:                      92135CCF-450D-4DAA-8FF5-E194218A69AF

Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x00000000069dcbc3

VM Regions Near 0x69dcbc3:
-->
   __TEXT                 0000000100000000-0000000100026000 [  152K] r-x/rwx SM=COW  /Users/USER/Library/Developer/Xcode/DerivedData/someApp-dzxzpbtokpnlvbfzxrgbssffgdva/Build/Products/Debug/someApp.app/Contents/MacOS/someApp

Application Specific Information:
objc[33571]: garbage collection is OFF
Performing @selector(someSelector:) from sender NSButton 0x1018170c0

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   com.myCompany.someApp            0x000000010000bab3 jk_encode_add_atom_to_buffer + 1075 (JSONKit.m:2605)
1   com.myCompany.someApp            0x000000010000ea8f jk_encode_add_atom_to_buffer + 13327 (JSONKit.m:2795)
2   com.myCompany.someApp            0x000000010000e3e8 jk_encode_add_atom_to_buffer + 11624 (JSONKit.m:2765)
3   com.myCompany.someApp            0x000000010000afd5 jk_encode + 581 (JSONKit.m:2831)
4   com.myCompany.someApp            0x000000010000ad83 -[NSArray(JSONKit) JSONDataWithOptions:error:] + 67 (JSONKit.m:2891)
5   com.myCompany.someApp            0x000000010000ad38 -[NSArray(JSONKit) JSONData] + 56 (JSONKit.m:2886)
6   com.myCompany.someApp            0x000000010000260d -[someAppAppDelegate someMethod:] + 157 (someAppAppDelegate.m:118)
7   com.apple.CoreFoundation       0x00007fff8ad626ad -[NSObject performSelector:withObject:] + 61
8   com.apple.AppKit               0x00007fff8998ed00 -[NSApplication sendAction:to:from:] + 139
9   com.apple.AppKit               0x00007fff8998ec32 -[NSControl sendAction:to:] + 88
10  com.apple.AppKit               0x00007fff89a14a4e -[NSCell _sendActionFrom:] + 137
11  com.apple.AppKit               0x00007fff89a14355 -[NSCell trackMouse:inRect:ofView:untilMouseUp:] + 2014
12  com.apple.AppKit               0x00007fff89a4313a -[NSButtonCell trackMouse:inRect:ofView:untilMouseUp:] + 489
13  com.apple.AppKit               0x00007fff89a12e7b -[NSControl mouseDown:] + 786
14  com.apple.AppKit               0x00007fff899393fc -[NSWindow sendEvent:] + 6288
15  com.apple.AppKit               0x00007fff898704a6 -[NSApplication sendEvent:] + 4847
16  com.apple.AppKit               0x00007fff89808593 -[NSApplication run] + 541
17  com.apple.AppKit               0x00007fff8980133d NSApplicationMain + 860
18  com.myCompany.someApp            0x0000000100001d32 main + 34 (main.m:13)
19  com.myCompany.someApp            0x0000000100001d04 start + 52

Thread 1:
0   libsystem_kernel.dylib         0x00007fff8cb771b2 __workq_kernreturn + 10
1   libsystem_c.dylib              0x00007fff897414d9 _pthread_wqthread + 758
2   libsystem_c.dylib              0x00007fff89742599 start_wqthread + 13

Thread 2 name:  Dispatch queue: com.apple.libdispatch-manager
Thread 2:
0   libsystem_kernel.dylib         0x00007fff8cb77806 kevent + 10
1   libdispatch.dylib              0x00007fff8cebaa26 _dispatch_mgr_invoke + 916
2   libdispatch.dylib              0x00007fff8cebb877 _dispatch_queue_invoke + 63
3   libdispatch.dylib              0x00007fff8cebb070 _dispatch_worker_thread2 + 198
4   libsystem_c.dylib              0x00007fff8974131f _pthread_wqthread + 316
5   libsystem_c.dylib              0x00007fff89742599 start_wqthread + 13

Thread 3:
0   libsystem_kernel.dylib         0x00007fff8cb771b2 __workq_kernreturn + 10
1   libsystem_c.dylib              0x00007fff897414d9 _pthread_wqthread + 758
2   libsystem_c.dylib              0x00007fff89742599 start_wqthread + 13

Thread 4:
0   libsystem_kernel.dylib         0x00007fff8cb771b2 __workq_kernreturn + 10
1   libsystem_c.dylib              0x00007fff897414d9 _pthread_wqthread + 758
2   libsystem_c.dylib              0x00007fff89742599 start_wqthread + 13

Thread 5 name:  com.apple.NSURLConnectionLoader
Thread 5:
0   libsystem_kernel.dylib         0x00007fff8cb756b6 mach_msg_trap + 10
1   libsystem_kernel.dylib         0x00007fff8cb74dad mach_msg + 73
2   com.apple.CoreFoundation       0x00007fff8ad291ec CFRunLoopServiceMachPort + 188
3   com.apple.CoreFoundation       0x00007fff8ac88a44 __CFRunLoopRun + 1204
4   com.apple.CoreFoundation       0x00007fff8ac88356 CFRunLoopRunSpecific + 230
5   com.apple.Foundation           0x00007fff86e77fca +[NSURLConnection(NSURLConnectionReallyInternal) _resourceLoadLoop:] + 335
6   com.apple.Foundation           0x00007fff86dff681 -[NSThread main] + 68
7   com.apple.Foundation           0x00007fff86dff5f9 __NSThread__main + 1575
8   libsystem_c.dylib              0x00007fff8973f804 _pthread_start + 335
9   libsystem_c.dylib              0x00007fff89742589 thread_start + 13

Thread 6 name:  com.apple.CFSocket.private
Thread 6:
0   libsystem_kernel.dylib         0x00007fff8cb76e12 __select + 10
1   com.apple.CoreFoundation       0x00007fff8aca7e1b __CFSocketManager + 1355
2   libsystem_c.dylib              0x00007fff8973f804 _pthread_start + 335
3   libsystem_c.dylib              0x00007fff89742589 thread_start + 13

Thread 0 crashed with X86 Thread State (64-bit):
 rax: 0x00000000069dcbc3  rbx: 0x00000001018170c0  rcx: 0x0000000000000000  rdx: 0x00007fff5fbfe468
 rdi: 0x00007fff5fbf8e00  rsi: 0x00007fff5fbf8f30  rbp: 0x00007fff5fbe69b0  rsp: 0x00007fff5fbdffa0
  r8: 0x0000000000000000   r9: 0x0000000100515d20  r10: 0x00007fff8ad62310  r11: 0x000000010011a540
 r12: 0x00007fff74c6b9f0  r13: 0x0000000101817400  r14: 0x000000010001e694  r15: 0x000000010182e0c0
 rip: 0x000000010000bab3  rfl: 0x0000000000010246  cr2: 0x00000000069dcbc3
Logical CPU: 4

Binary Images:
      0x100000000 -        0x100025ff7  com.myCompany.someApp (1.0 - 1) <50EC498D-ED9C-321A-B86B-224B4DA9AD55> /Users/USER/Library/Developer/Xcode/DerivedData/someApp-dzxzpbtokpnlvbfzxrgbssffgdva/Build/Products/Debug/someApp.app/Contents/MacOS/someAppsomeApp

     VM Region Summary:
ReadOnly portion of Libraries: Total=135.9M resident=70.0M(52%) swapped_out_or_unallocated=65.9M(48%)
Writable regions: Total=130.6M written=17.8M(14%) resident=27.5M(21%) swapped_out=0K(0%) unallocated=103.1M(79%)

REGION TYPE                      VIRTUAL
===========                      =======
CG backing stores                  5036K
CG image                             32K
CG raster data                      312K
CG shared images                   4496K
Carbon                             2324K
Core Image                           12K
CoreGraphics                         16K
MALLOC                             90.5M        see MALLOC ZONE table below
MALLOC freed, no zone              2588K
MALLOC guard page                    48K
MALLOC metadata                     540K
Memory tag=240                        4K
Memory tag=242                       12K
Memory tag=243                        8K
Memory tag=251                        8K
OpenCL                               12K
SQLite page cache                  1344K
STACK GUARD                        56.0M
Stack                              10.6M
VM_ALLOCATE                        16.1M
__CI_BITMAP                          72K
__DATA                             11.1M
__IMAGE                            1244K
__LINKEDIT                         43.4M
__TEXT                             92.5M
__UNICODE                           544K
mapped file                        35.5M
shared memory                       312K
===========                      =======
TOTAL                             374.3M

                                         VIRTUAL ALLOCATION      BYTES
MALLOC ZONE                                  SIZE      COUNT  ALLOCATED  % FULL
===========                               =======  =========  =========  ======
DefaultMallocZone_0x10003a000               80.4M      70135      13.7M     16%
DispatchContinuations_0x10006c000           6144K          1         32      0%
unnamed_zone_0x1004fa000                    4096K          8        480      0%
CoreGraphics_0x102000c00                      80K        618        12K     15%
x-alloc_0x1008a5400                            0K          2        224
DefaultPurgeableMallocZone_0x101fa8000         0K          0         0K
===========                               =======  =========  =========  ======
TOTAL                                       90.5M      70764      13.7M     15%

Model: MacPro5,1, BootROM MP51.007F.B00, 4 processors, Quad-Core Intel Xeon, 2.8 GHz, 8 GB, SMC 1.39f11
Graphics: ATI Radeon HD 5770, ATI Radeon HD 5770, PCIe, 1024 MB
Memory Module: DIMM 1, 2 GB, DDR3 ECC, 1066 MHz, 0x80AD, 0x484D54313235553742465238432D47372020
Memory Module: DIMM 2, 2 GB, DDR3 ECC, 1066 MHz, 0x80AD, 0x484D54313235553742465238432D47372020
Memory Module: DIMM 3, 2 GB, DDR3 ECC, 1066 MHz, 0x80AD, 0x484D54313235553742465238432D47372020
Memory Module: DIMM 4, 2 GB, DDR3 ECC, 1066 MHz, 0x80AD, 0x484D54313235553742465238432D47372020

I observe memory leaks, which may be quite significant for me.

I do the following code in my view controller:

JSONDecoder *json = [JSONDecoder decoder];

if (![data isKindOfClass:[NSData class]])
{
    // Error occurred
    return;
}

// Ok, data is received, parse it
NSDictionary *parsed = [json objectWithData:data];

As soon as I move to another controller I get:

Leaked Object # Address Size Responsible Library Responsible Frame
NSCFString,5 < multiple > 144 Bytes App jk_cachedObjects
NSCFString,1 0x18ac40 32 Bytes App jk_cachedObjects
NSCFString,1 0x18b340 16 Bytes App jk_cachedObjects
NSCFString,1 0x18b7e0 32 Bytes App jk_cachedObjects
NSCFString,1 0x18bc90 32 Bytes App jk_cachedObjects
NSCFString,1 0x18cb60 32 Bytes App jk_cachedObjects

id Address Category Event Type RefCt Timestamp Size Responsible Library Responsible Caller
0 0x18ac40 CFString (immutable) Malloc 1 00:15.891.265 32 App jk_cachedObjects
1 0x18ac40 CFString (immutable) CFRetain 2 00:15.891.302 0 App jk_cachedObjects
2 0x18ac40 CFString (immutable) CFRetain 3 00:15.903.345 0 Foundation -[NSCFString retain]
3 0x18ac40 CFString (immutable) CFRelease 2 00:15.973.275 0 App -[JKDictionary dealloc]
4 0x18ac40 CFString (immutable) CFRelease 1 00:15.980.459 0 App -[JSONDecoder clearCache]

I shouldn't do the following, is it? At least it's not obvious that I should.

[json release];
[parsed release];

I parse lots of data (at least once each 5 minutes), so such leak is quite critical for me.
Can you be so kind as to dig into this? May be it's just my stupid fault, but it doesn't look like that for me right now.

It would be nice to have JSON Schema validation.

Does JSONkit work with arrays? Ive got the following and using NSLogs I seem to have gotten my data correctly, but I am having some issues with tableview and the errors are new to me.

NSString *myJSON = @"http://www.example...";
NSData *jsonData = [NSData dataWithContentsOfURL:[NSURL URLWithString:myJSON]];
JSONDecoder *jsonKitDecoder = [JSONDecoder decoder];

myArray = [jsonKitDecoder objectWithData:jsonData]; //an array i declared in .h

the feed is an array of dictionaries and I've been able to use nested objectForKey, valueForKey and objectATIndex messages to get to all the data I want. I've even gotten it displayed in my tableview when the app first opens. The problem is as soon as i try and scroll the app crashes.

In the code editor, I get "Thread 1: Program received signal: "SIGABRT" on a line in titleForHEaderInSection: return [[myArray objectAtIndex:section] valueForKey:@"key"]; I've got the following right above that and that outputs to the log correctly, so its something to do with the scrolling and going to the next section thats off screen: NSLog(@"classser %@", [[[industries objectAtIndex:section] valueForKey:@"industry"]description]);

In the console I get "Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: (objects != NULL) && (count <= capacity) && (objects[objectIndex] != NULL)'". It takes me to line 745 of JSONKit.m which is an assertion in obejctatIndex ( NSParameterAssert((objects != NULL) && (count <= capacity) && (objects[objectIndex] != NULL)); ) I'm not adhering to, but I just don't know how as everything else I do shows my array and dictionaries as working.

Let me know what else you need as I'm still new to all this

When JSONData is called on a NSDictionary that has a key value pair that has a string encoded with ASP.NET Date format (http://weblogs.asp.net/bleroy/archive/2008/01/18/dates-and-json.aspx) the backslash in the date format is incorrectly escaped with another backslash.

For example:

"/Date(1303502009425)/"

is encoded as:

"/Date(1303502009425)/"

This should not be the case because the JSON spec indicates that the forward slash can optionally be escaped.

Question: The github page for this project states BSD license, but the code has Apache 2. Could you clarify?

Thanks,
Dominic
@dominicdimarco

I would try to do this myself but the level of sophistication in JSONKit is far beyond me. Perhaps this wouldn't even be possible without really slowing JSONKit down?

Anyways, there are two problems I have that could be fixed by something like this.

1. Our company's JSON passes dates as strings in the format "/Date(1305758490476)/" (This is something that .net does). It would be great if I could have a callback, see this is in the date format, and return an NSDate.
2. I hate NSNulls! I know that sometimes you really need to keep nulls in your collections, however, usually NSNulls cause a lot more work. For example, I get a url for an image. I have to double check that it's not an NSNull before creating an NSURL from the string. What a pain! The other option I'm left with is going through all the objects manually and getting rid of NSNulls. So I would like to get a callback and return nil so the NSNull won't be added in.

Anyways, thoughts?

As of 862fa4d, line 2793 reads like this:

if((encodeState = (struct JKEncodeState *)calloc(1UL, sizeof(JKEncodeState))) == NULL) { [NSException exceptionWithName:NSMallocException reason:@"Unable to allocate state structure." userInfo:NULL]; return(NULL); }

That, in case of a memory problem will create the exception object and not do anything with it. I think is missing a @throw statement, or creating the exception using a +[NSException raise:format:] method (like is done in the rest of the file).

[NSException raise:NSMallocException format:@"Unable to allocate state structure."]

Do an updated benchmark against NSJSONSerialization.

I got a EXC_BAD_ACCESS occasionally on line 958:

- (void)dealloc
{
  if(JK_EXPECT_T(entry != NULL)) {
    NSUInteger atEntry = 0UL;
    for(atEntry = 0UL; atEntry < capacity; atEntry++) {
// following line: 958
      if(JK_EXPECT_T(entry[atEntry].key    != NULL)) { CFRelease(entry[atEntry].key);    entry[atEntry].key    = NULL; }
      if(JK_EXPECT_T(entry[atEntry].object != NULL)) { CFRelease(entry[atEntry].object); entry[atEntry].object = NULL; }
    }

    free(entry); entry = NULL;
  }

  [super dealloc];
}

Hi John,

I'm just trying to learn and understand your marvelous code :). I saw this and was confused by it. If you have a second I thought you might shed some light.

#if       defined (__GNUC__) && (__GNUC__ >= 4)
#define JK_ATTRIBUTES(attr, ...)        __attribute__((attr, ##__VA_ARGS__))
#define JK_EXPECTED(cond, expect)       __builtin_expect((long)(cond), (expect))
#define JK_EXPECT_T(cond)               JK_EXPECTED(cond, 1U)
#define JK_EXPECT_F(cond)               JK_EXPECTED(cond, 0U)
#define JK_PREFETCH(ptr)                __builtin_prefetch(ptr)
#else  // defined (__GNUC__) && (__GNUC__ >= 4) 
#define JK_ATTRIBUTES(attr, ...)
#define JK_EXPECTED(cond, expect)       (cond)
#define JK_EXPECT_T(cond)               (cond)
#define JK_EXPECT_F(cond)               (cond)
#define JK_PREFETCH(ptr)
#endif // defined (__GNUC__) && (__GNUC__ >= 4) 

JK_EXPECT_T looks like it's supposed to return true if the condition is true and JK_EXPECT_F looks like it's supposed to return true if the condition is false. But in the #else section they both return the same thing. Is this a bug or something that makes sense when defined (__GNUC__) && (__GNUC__ >= 4) is false?

Hello,
Can you please add support for NSDate type. I would think you could just map NSDate/CFDate to a String.

Thanks!

Hello,

I have this JSON string:

{"data":
{77: {"number": 0, "photo": ""},
{78: {"number": 3, "photo": ""},
...
};

My code is:

JSONDecoder *jsDecoder = [JSONDecoder decoder];
NSArray *arrayElements = [jsDecoder objectWithData:responseDara error:&msgError];

To decode gives the error "Error Domain = JKErrorDomain Code = 1 " Expected to "STRING" or a '}', not '77' "
What is wrong?

test environment XCode4

line 2318

- (id)objectWithUTF8String:(const unsigned char *)string length:(NSUInteger)length error:(NSError **)error
{
  if(parseState == NULL) { [NSException raise:NSInternalInconsistencyException format:@"parseState is NULL."];          }
  if(string     == NULL) { [NSException raise:NSInvalidArgumentException       format:@"The string argument is NULL."]; }

  return(_JKParseUTF8String(parseState, NO, string, (size_t)length, error));
}

What are your thoughts on adding support for parsing streams of JSON-encoded data? Would there be enough of a speed gain to warrant this type of parsing for webservices that return large amounts of data?

Thank you so much for this project. So far it has been both easy to use and incredibly fast.

Why is the Unicode NULL codepoint, when properly escaped, invalid? That is, a string like "Testing\u0000Hello world"

isValidCodePoint returns sourceIllegal for the NULL character (ch == 0U). The headers say:

The code in isValidCodePoint() is derived from the ICU code in
utf.h for the macros U_IS_UNICODE_NONCHAR and U_IS_UNICODE_CHAR.

However, U_IS_UNICODE_CHAR(0) returns true.

In addition, RFC 4627 makes a passing reference to U+0000 as being allowed:

Any character may be escaped. If the character is in the Basic Multilingual Plane (U+0000 through U+FFFF), then it may be represented as a six-character sequence

I can of course use the LooseUnicode option to replace it, but that's not ideal since it is valid JSON as far as I can tell.

Hello,
could you please show a snippet of basic decoding with objectWithData? thanks

I'm using the following code

self.decoder=[JSONDecoder decoderWithParseOptions:JKSerializeOptionNone];

NSError *error = nil;
NSObject *jsonObj = [decoder objectWithData:data error:&error];
if (data == nil || error) { // parsing or data error
    [self handleError:error];
    return;
}

// TODO: do something with NSObject

Hi there,
I started using JSONKit library and I really enjoyed the speed of the parsing. its really fast as you guys say.
but I am having a problem when parsing a JSON with one of the values is null:
...
"somekey" : null

the dictionary in return will show up as

...
"somekey" = "";

is there a way to fix this locally for now ?

1. Parse JSON in NSData format by calling -objectFromJSONData
2. Invoke -mutableCopy on the result
3. Release (or autorelease) the result of -mutableCopy

The application will crash in JSONKit code. The crash point is as follows:

Thread 0 Crashed: Dispatch queue: com.apple.main-thread
0 CoreFoundation 0x00e8b057 _forwarding_ + 183
1 CoreFoundation 0x00e8af22 _CF_forwarding_prep_0 + 50
2 CoreFoundation 0x00e30a6c CFRelease + 92
3 CrashJSONKit 0x00001e7d jk_CFCallbackRelease + 17 (JSONKit.m:312)
4 CoreFoundation 0x00e53b22 __CFArrayReleaseValues + 178
5 CoreFoundation 0x00e30bcb _CFRelease + 251
6 CoreFoundation 0x00e55b8d _CFAutoreleasePoolPop + 237
7 Foundation 0x0001f443 -[NSAutoreleasePool release] + 167
8 UIKit 0x002d0bf2 _UIApplicationHandleEvent + 8792
9 GraphicsServices 0x0184fa36 PurpleEventCallback + 1550

I've created a minimal sample project which exhibits the crash. The above code is all that exists in it other than standard app setup code. It doesn't have any strange build flags or link against any non-vanilla frameworks.

Download the sample project at: http://dl.dropbox.com/u/102780/CrashJSONKit.zip

This is on Xcode 3.2.5 against iOS SDK 4.2.

I have had great success using JSONKit -- however today I was getting a crash in _JKDictionaryHashTableEntryForKey. As I dug in, it seems that dictionary->capacity was NULL, and the code was dying here:

NSUInteger keyHash = CFHash(aKey), keyEntry = (keyHash % dictionary->capacity), idx = 0UL;

I added a NULL check immediately above:

if(!dictionary->capacity) { return(NULL); }

and now things seem to be going through.

Jack

Hi John,

There's a bug in _JKDictionaryHashTableEntryForKey which returns an incorrect result (returns an object when it should return NULL) if the key falls into the same bucket as another key, but the hash and value don't match.

The loop does:

atEntry = &dictionary->entry[(keyEntry + idx) % dictionary->capacity];

But never clears atEntry if we get to the end of the loop and the key wasn't found.

Thanks!

Regards,
Omar

Hi,

There is a problem with the NSMutableDictionary returned by mutableObjectFromJSONString. A call to removeObjectsForKeys will remove the objects but not the keys. So we end up with nil objects. I also noticed side effects on other dictionary values that should not be affected.

Should it be overridden in the JKDictionary class like removeObjectForKey is?

Thanks,
JF

I tried this and I got back regular ole NSData. so I'm guessing this is not working at this time, can you confirm. or am i missing something else?
Jeremy

With JSONKit HEAD as of 1/26/11:
JSONKit.m:356: warning: 'calculateNumberHash' declared 'static' but never defined

At first glance it looks safe to delete that line, but I wonder whether it's perhaps meant to be used somewhere (but isn't).

(Building with Xcode 3.2.5, iOS 4.2 SDK)

I am using ASIHTTP to download gzip'd data, that is then passed to JSONkit.

ASI has memory issues that can be addressed by wrapping the calls in a
NSAutoreleasePool then releasing when done. I am downloading a LARGE ( very Large) amount of data and I release the NSAutoreleasePool after every download because ASI will eat a few MB in a few calls..
The side affect of this is the JSONKit calls are also inside the NSAutoreleasePool / release code. When I release my NSAutoreleasePool I receive and error saying JKDictionary release]; was over released and the app crashes.

Any ideas how this can be addressed?
Jeremy

aKey = [ aKey copy ]; Looks like it could be leaking. We created about 30 objects then released them and ended up with a much larger footprint than we should have had in quick check.

Also in several places where you do anObject = [ anObject retain ]; should probably be [ anObject retain ]; since the assignment is technically considered "dead code" by the static analyzer.

Hi John,

Not really a big deal and I'm not sure if this is related to the recent JKSerializer class, but I'm finding that encodes are 10-20% slower than my last test (with commit 524b9d7).

Do you see a similar drop?

Regards,
Omar

if I run this code:

static NSString * key = @"doubleKey";
NSNumber * doubleNumber = [NSNumber numberWithDouble:22];
NSMutableDictionary * dict = [NSMutableDictionary dictionary];
[dict setObject:doubleNumber forKey:key];
NSLog("%@", [dict JSONString]);

I get this json:

{"doubleKey":22}

I'm not intimately familiar with the JSON spec, but this encoding was causing me some problems where I expected a double to come back on decode, but an int came back.

I implemented a possible fix locally, but I'd like to hear feedback before I fork and submit a pull request. The fix is to change the format string at https://github.com/johnezang/JSONKit/blob/master/JSONKit.m#L2755, which is currently "%.17g" to "%#.17g" in order to force trailing zeroes for double values that are also whole numbers.

What license are you distributing this under? MIT, GPL, etc...

With the following build options enabled, there are 21 errors:

Implicit Conversion to 32 Bit Type
Implicit Signedness Conversions
Suspicious Implicit Conversions
Overriding Deprecated Objective-C Methods

It would be awesome if JSONKit didn't cause errors with these options enabled. I tried fixing the issues, but your crazy C stuff is a bit over my head.

Any plan on supporting this like TouchJSON and other parsers do? For now I've added an NSDictionary category that checks for null values and return nil instead. I've tried adding that directly to the parser but that code is way beyond my knowledge ^^

Instead of (or in addition to) using blocks to serialize unsupported class types, perhaps a protocol could be used. Classes would implement this protocol in order to be serialized naturally.

I would like to discuss your future plans for supporting Automatic Reference Counting (ARC). I see in commit c2146ff that you added a section to the README in which you state:

JSONKit is not designed to be used with Objective-C Automatic Reference Counting (ARC). The behavior of JSONKit when compiled with -fobjc-arc is undefined. The behavior of JSONKit compiled without ARC mixed with code that has been compiled with ARC is normatively undefined since at this time no analysis has been done to understand if this configuration is safe to use. At this time, there are no plans to support ARC in JSONKit. Although tenative, it is extremely unlikely that ARC will ever be supported, for many of the same reasons that Mac OS X Garbage Collection is not supported.

Is this the long-term plan? What are your reasons for not supporting ARC?

Note: Edited to remove unsubstantiated claims about ARC, as well as a dumb suggestion for creating an ARC branch of the code. No one wants to maintain two branches for something like this.

I'm assuming you have some form of automated tests, and I think these should be available in the repository. For those of us making modifications on the codebase it's pretty essential that we have some tests to make sure we are not breaking stuff.

Any chance of adding this?

The following code will crash in Mac OS X Lion Developer Preview 2:

[[NSArray arrayWithObject:[NSNumber numberWithInteger:1]] JSONString]

The crash happens when you try to get the isa value for the number object because they seem to be optimized special pointers in the runtime now.

With the following jsonstring, I have access to pilots:

{
"1": {
"name": "XXX",
"pilots": {
"pilot": {
"name": "YYYY",
"image": "",
"years": "28"
},
"copilot": {
"name": "ZZZZ",
"image": "",
"years": "24"
}
}
},
"2": {
"name": "XXX",
"pilots": {
"pilot": {
"name": "YYYY",
"image": "",
"years": "28"
},
"copilot": {
"name": "ZZZZ",
"image": "",
"years": "24"
}
}
}
}

with this code get elements 1 and 2 but How to access pilot elements?

JSONDecoder *jDecoder = [JSONDecoder decoder];
NSDictionary *dVehicles = [jDecoder objecttWithData:responseData error:&msgError];

Thanks.