Allow importing kirby/panel files for plugins ? about kirbyup HOT 6 CLOSED

Just to report back: Custom aliases are working perfectly ! :)
Thanks for your efforts on kirbyup, it's flawless to use.

from kirbyup.

Hi there, good idea in general.

Quick question, tho: How should kirbyup know, which base path @ should resolve to? A simple alias to ~ wouldn't do. It would have to guess something like kirby/panel/src in the path, which then if someone uses just panel/src could possibly not be related to Kirby's Panel source at all. I can't think of a clean way to provide this functionality yet.

from kirbyup.

I could think of executing kirby()->roots('kirby') to get the kirby root, but that would mean relying on php... possible ? We still need to find kirby for this though.

Parsing kirby's config files might be a bit excessive and unreliable; otherwise recursively searching folders for the kirby dir (brute force), but that might break on some very specific setups...

And/Or assume we're in a classic installation (project/kirby and project/kirby/site/plugins/plugindir) and let users change their kirby root via a preferences file ?

from kirbyup.

Executing PHP for the Kirby root is unfortunately neither a semantic, nor practical way.

I honestly don't want to include an assumption-based logic. Many plugins written aren't part of an installation, but rather outsourced into their respective repo.

For your (edge?) case, I recommend just copying Kirby's panel folder to the same level as your plugin's JS entry. We could then add @ as an alias to ~, which would make Kirby's internal paths work.

from kirbyup.

Thanks, didn't think about that option, even better, creating a symlink to kirby files instead of copying them.
What about making @ point to plugin/kirby, kirby being an optional folder or alias one can use to point to Kirby.
Meanwhile I'm curious what the kirby team's position is about extending core components.

from kirbyup.

Symlink sounds great. I'm not a fan of some custom subfolder, since @/ is common as a root directory name alias (just like ~/). Thus, I don't intend to break an expected behavior. Symlinking panel will work just as well.

Added a secondary alias in d4c479c, available in kirbyup 0.20.0+.

Please open a separate issue over at the Kirby repo for your question on Panel source reusability within Panel plugins. Thanks!

Edit: I intend to add support for a custom kirbyup.config.js, but that will have to wait a bit.

from kirbyup.