Comments (6)
Nevertheless, a fix would require changes to the vue-grid-layout. You could duplicate the components of the library and replace the EventBus with another library.
Indeed, thank you for the advice! I imported a custom version of the library, using mitt
as eventBus and it works well.
I don't know how Parcel handled this behavior. Maybe it bundled Vue itself into the Panel build? How big was your bundle?
The previous build with Parcel v1 was 230kb
, now with kirbyup and without the Vue import it weights 131kb
!
Thank you again for your help!
from kirbyup.
I appreciate you took the time to refactor the library. Occasionally I give tips on how to implement something in an issue, which then doesn't happen because of the effort involved for the person asking. Glad to know that the effort for myself writing the answer was worth it!
from kirbyup.
If I may add : vue-grid-layout 2.4.0
is installed as a dependency and the GridLayout
and GridItem
components are imported from vue-grid-layout
inside a wrapper component which is used for the panel field.
from kirbyup.
Seems like the vue-grid-layout
library imports Vue to use it as an EventBus. Since Vue is imported in the library, kirbyup will externalize it.
A cleaner solution would be to use a library like mitt for the EventBus, instead of initializing Vue. The latter one was/is common in Vue 2 contexts. Vue 3 dropped this feature.
Nevertheless, a fix would require changes to the vue-grid-layout
. You could duplicate the components of the library and replace the EventBus with another library.
I don't know how Parcel handled this behavior. Maybe it bundled Vue itself into the Panel build? How big was your bundle?
from kirbyup.
FWIW, I've raised the core issue β Kirby exposing the Vue constructor only via use
so plugins can't target it β in getkirby/kirby#4735. Aside from the occasional compat issues we have like this one or #8, the way Vue is provided right now also completely prohibits using Vue 2.7 functionality like dynamic CSS variables or setup
functions :(
from kirbyup.
Great! Thank you so much for raising that discussion up!
from kirbyup.
Related Issues (20)
- kirbyup fails silently HOT 3
- Kirby, Kirbyup & Tailwind class order issue HOT 2
- [vite:css] Cannot read properties of undefined (reading 'config') HOT 9
- Bump to v1.0.0 HOT 1
- Support dev server mode w/ HMR HOT 8
- Extremely slow starts if kirbyup.config exists HOT 3
- Asset strategy HOT 1
- Invalid Url Error when using kirbyup serve HOT 4
- Adding external librairies HOT 1
- Wrong types for `kirbyup.import()` HOT 2
- HMR throws error in Kirby 3.8.3 HOT 4
- Incompatible Node version HOT 1
- Vue component file naming convention ? HOT 3
- Debugging Vue HOT 1
- Error with HTTPS and WSS
- Missing __file property breaks HMR in beta version HOT 1
- Canβt enable sourcemaps HOT 1
- Access Vite server from DDEV server HOT 12
- How to use code splitting? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kirbyup.