Giter Club home page Giter Club logo

Comments (4)

johannschopplich avatar johannschopplich commented on May 30, 2024 1

@Basics09 fixed by @jonaskuske. Thank you both!

Fix will land in kirbyup v2.0.1.

from kirbyup.

johannschopplich avatar johannschopplich commented on May 30, 2024

Could you provide a minimal reproducible example with your code, please?

A repo would be just fine. Thanks in advance!

from kirbyup.

ovenum avatar ovenum commented on May 30, 2024

Sure it’s pretty bare-bones: https://github.com/basics09/kirbyup-issue-22/ : )

Looking at line 3429 in node_modules/kirbyup/dist/shared/kirbyup.1b72ea0c.mjs the issue is emitted from inside configureServer().

The address property of server.httpServer.address() is ::1 when i try to run the script.
Editing the file and replacing it with the IPv4 loopback address will run the script but of course HMR will not work since the server was configured with the IPv6 loopback address.

This probably boils down to node URL in v18.6.0 not handling IPv6 correctly?

from kirbyup.

ovenum avatar ovenum commented on May 30, 2024

After upgrading to node v18.8.0 i found the issue.

IPv6 addresses inside a URL have to be enclosed in square brackets [ ] as by the RFC Spec

configureServer should maybe try to detect if a IPv4 or IPv6 address is used. Not that deep into node, maybe httpServer.address() does this somewhere already? After that baseUrl can be build with IPv6 addresses working correctly.

kirbyup/src/node/plugins/hmr.ts

Lines 58 to 62 in 1236007

server.httpServer.once('listening', async () => {
const entryPath = entry.replace(`${config.root}/`, '')
const { address, port } = server.httpServer!.address() as AddressInfo
const baseUrl = `http://${address}:${port}${config.base}`
const entryUrl = new URL(entryPath, baseUrl).href

Currently baseUrl will be something like this http://::1:5177/ but should be http://[::1]:5177 for IPv6 Urls.

from kirbyup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.