jim-rhoades / divingboard Goto Github PK

Hey Jim, great contribution here! Thanks.

I'd like to make a suggestion. I don't believe the Storyboard/Segues to PhotoCollectionViewController are necessary to only house PhotoCollectionViewCell. I think it would be much easier to read the code if created programmatically.

What do you think?

Thinking about how people will actually use this, the user interface could be simplified. The "Curated" photos tab isn't something that people will use much, and the "New" and "Search" screens could be combined in one.

The benefits would be:

1. one less tap needed to start a search
2. potential for reduced memory usage (one view controller/collection view worth of photos in memory vs. up to three)

The downsides would be:

1. a UISearchBar always showing... though it wouldn't take up much more screen space than the CollectionTypePickerView does now
2. no way to view "Curated" photos, but again I don't think anybody would miss that

So, the CollectionTypePickerView should be removed completely, and DivingBoard should start by showing "New" photos with the search bar available directly on that screen.

Also, a "Cancel" button will need to be added next to the search bar (otherwise, once you start a search there would be no way to go back to viewing "New" photos).

Occasionally, when scrolling quickly through photos the same photo can end up being displayed in more than one cell.

(Most likely something to do with cell reuse and loading the photo thumbnails asynchronously... but I haven't had a chance to dig into this problem yet.)

Is there a reason you're requiring SDK > 11? It's always best to set it to at least -1 major version, especially if you don't need the latest features.

[!] CocoaPods could not find compatible versions for pod "DivingBoard":
  In Podfile:
    DivingBoard (~> 1.1)

Specs satisfying the `DivingBoard (~> 1.1)` dependency were found, but they required a higher minimum deployment target.