jim-rhoades / divingboard Goto Github PK
View Code? Open in Web Editor NEWAn iOS framework that provides an interface for browsing and searching for photos from Unsplash.com.
License: MIT License
An iOS framework that provides an interface for browsing and searching for photos from Unsplash.com.
License: MIT License
Hey Jim, great contribution here! Thanks.
I'd like to make a suggestion. I don't believe the Storyboard/Segues to PhotoCollectionViewController
are necessary to only house PhotoCollectionViewCell
. I think it would be much easier to read the code if created programmatically.
What do you think?
Thinking about how people will actually use this, the user interface could be simplified. The "Curated" photos tab isn't something that people will use much, and the "New" and "Search" screens could be combined in one.
The benefits would be:
The downsides would be:
So, the CollectionTypePickerView should be removed completely, and DivingBoard should start by showing "New" photos with the search bar available directly on that screen.
Also, a "Cancel" button will need to be added next to the search bar (otherwise, once you start a search there would be no way to go back to viewing "New" photos).
Occasionally, when scrolling quickly through photos the same photo can end up being displayed in more than one cell.
(Most likely something to do with cell reuse and loading the photo thumbnails asynchronously... but I haven't had a chance to dig into this problem yet.)
Is there a reason you're requiring SDK > 11? It's always best to set it to at least -1 major version, especially if you don't need the latest features.
[!] CocoaPods could not find compatible versions for pod "DivingBoard":
In Podfile:
DivingBoard (~> 1.1)
Specs satisfying the `DivingBoard (~> 1.1)` dependency were found, but they required a higher minimum deployment target.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.