Time Zone Support Broken about stamp HOT 8 CLOSED

Even the examples in the readme regarding timezone don't work!! :(

from stamp.

@ramaboo Can you add a failing test on a branch that reproduces the issue?

from stamp.

I don't know Minitest (Rspec here). The test is simple though in rails console type:

time = Time.utc(2011, 6, 9, 20, 52, 30)
time.stamp("23:59 UTC")             #=> "20:52 PST"

And you will see it's broken.

from stamp.

Here's what I just got:

irb(main):002:0> time = Time.utc(2011,6,9,20,52,30)
=> 2011-06-09 20:52:30 UTC
irb(main):003:0> time.stamp("23:59 UTC")
=> "20:52 UTC"

I wonder if something is modifying the behavior of the Time class. Are you
in a Rails app? What version of Ruby/Rails?

On Mon, May 23, 2016 at 6:55 PM, David Singer [email protected]
wrote:

I don't know Minitest (Rspec here). The test is simple though in rails
console type:

time = Time.utc(2011, 6, 9, 20, 52, 30)
time.stamp("23:59 UTC") #=> "20:52 PST"

And you will see it's broken.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#29 (comment)

from stamp.

Yeah Rails 4.2.6. I get the same thing as you but in your documentation you state the result should be "20:52 PST" not "20:52 UTC" I can't find a way to get `time.stamp('23:59 UTC') to return a string without UTC in it. No matter what I do it never turns UTC to PST or EST, etc.

from stamp.

That looks like a bad example in the documentation. However, I'm not sure convinced time zones are working correctly. I would expect stamp to emit the zone of the time object you're operating on, but that's not happening. It's been a while since I've been in that code, but it appears to use ENV['TZ'] to determine the current zone, not based on the zone of the time object.

I don't have a ton of time to investigate further right now, but please let me know if you discover anything or come up with a fix.

from stamp.

require 'active_support/all'
Time.current.stamp("UTC")
# => "EDT"  
Time.current.in_time_zone('MST').stamp("UTC")
# => "UTC"

looks like it probably thinks TimeWithZone is a Date and not a time.
will look into it

from stamp.

also of interest

DateTime.now.stamp("UTC")
# => "-04:00"  

require "active_support/time"
ActiveSupport::TimeWithZone.send(:include, ::Stamp)
Time.current.in_time_zone('MST').stamp("UTC")
# => "MST"

the method is not defined in TimeWithZone (as we know) and it tries to create a Time object but
ruby/2.2.2/gems/tzinfo-1.2.2/lib/tzinfo/timezone_period.rb:145 seems to be loosing the timezone. and the wrap with timezone is not able to get it back in time.

from stamp.