jeffzh4ng / iruka Goto Github PK

I'm talking about this call:

This call should not always happen here, as it can cause the compare function to be called with undefined values while the compare function should only receive whatever the generic heap value type is.

This is causing an issue for me when constructing a MinHeap with heapify as I'm storing key-value pairs in a length-2 array. My compare function ((a, b) => a[0] - b[0]) is being called even though indexOutOfBounds is true, which causes undefined to be passed as b, causing TypeError: Cannot read property '0' of undefined.

Inlining the function call fixes it:

const indexOutOfBounds = leftChildIndex >= this.size()
if (indexOutOfBounds || this.less(k, smallestIndex)) break

Alternatively the bound check can be put in the while condition

With semantic-release and commitizen

Create the HelloWorld data structure

In LinkedList implementation:

link
in line 116 I think this should be (i > list.size()) no equal needed as we already checked it in the previous if condition and we only want to make sure it's not bigger than list bound.

in line 120: I think we should loop until
j < i
not
j < i -1,

 for (let j = 0; j < i; j++) {
      cur = cur.next
    }

we need current pointer to hold the node before the ith node, so if i = 3 we want it to be the third node in the list so cur should point to i -1 that is 2

OR you missed = sign

 for (let j = 0; j <= i -1; j++) {
      cur = cur.next
    }

and If you approve I can make PR with these changes
PS: thank you so much I really enjoyed your videos :)