jasudev / axiscontribution Goto Github PK

After updating from 0.5.0 to main, I noticed a difference in the way the current week is displayed.

Previously, the cells in the week would only be visible up to and including the current day (say, Tuesday), with Wednesday - Saturday being the background color.

Now, all cells of the current week are visible, and are gray if they have no data.

It feels like this is a regression, because in theory, days in the future shouldn't have any data, so they shouldn't be displayed at all. It also helps the user visualize where they are in the current week.

When there's data like Date(): ACData(date: Date(), count: 5), It's blank for today's grid.

Also, the first week doesn't show correctly. While today is Tuesday, it shouldn't show the complete week with 7 days. There should be only 3 grids instead of 7, under the situation that Sunday is the first weekday.

Reproduce:
When the preview code is like this:

struct ACGridStack_Previews: PreviewProvider {
    static var previews: some View {
        AxisContribution(
            constant: .init(),
            source: [
                Date(): ACData(date: Date(), count: 5)
            ]
        )
        .padding()
    }
}

This is the result:

Following code does not work due to Color(hex: 0xF0F0F0) is not accessible from outside of package.

AxisContribution(constant: .init(), source: [Date(), Date()]) { indexSet, data in
    Image(systemName: "heart.fill")
      .foregroundColor(Color(hex: colorScheme == .dark ? 0x171B21 : 0xF0F0F0)) // compile error
      .font(.system(size: rowSize))
      .frame(width: rowSize, height: rowSize)
} foreground: { indexSet, data in
    Image(systemName: "heart.fill")
      .foregroundColor(Color(hex: 0x6CD164)) // compile error
      .font(.system(size: rowSize))
      .frame(width: rowSize, height: rowSize)
}

Could we have the Days of the Week always be visible? This would make it easier to understand for a first time user. I would suggest having it overlayed. I tried doing it myself but I don't have enough experience with custom layouts and calendars.

For instance, when I change the the First Day of Week from Sunday to Monday

The grid adjusts well accordingly (BTW, it's Monday on April 1st while I'm typing...)

But the weekday tooltip doesn't change accordingly.

It still marks the second row as Mondays.

This lib is so cool, but when I tried it in Widget, I got following error, it just me?

Thread 3: EXC_RESOURCE (RESOURCE_TYPE_MEMORY: high watermark memory limit exceeded) (limit=30 MB)

Xcode Version 14.2 (14C18)

When create object from ACData, xcode throws error like title describe. And after adding public for init the error was gone.