jakipatryk / steeditor Goto Github PK

Right now, the Community field is required, but it should be optional.

To do:

• Remove Validators.required (here)
• Change text on the label into something that does not contain a word "required" (here)
• Remove error hint (here)
• Remove error message from the class (here)
• Remove specs (this and this)

Expected behavior

steeditor should put URLs and user mentions from the post body in the corresponding json_metadata fields

Actual behavior

• non-markdown links are not included in json_metadata['links']. This is a problem for the utopian templates, since they propose the target repository as non-markdown links, but the utopian-spreadsheet repo parses json_metadata['links'] for that string:
  https://github.com/amosbastian/utopian-spreadsheet/blob/b4953e9af7910ffc3336a1945c3b31ae16aafb72/spreadsheet.py#L50
  The target repository is not necessarily detected correctly in this case.

• user-mentions are found within markdown URLs. This is not necessarily a bug, only inconsistent to other interfaces.

How to reproduce

Two test posts with the same body: utopian template + one image + a markdown link

• from steeditor: steemd

{"app":"steeditor/0.1.0",
"format":"markdown",
"image":["https://steemitimages.com/0x0/https://user-images.githubusercontent.com/33018033/42889616-25f17de6-8aab-11e8-971e-e05abdb331e1.png"],
"tags":["not-utopian","not-analysis"],
"users":["stmdev"],
"links":["https://steemit.com/test/@stmdev/steeditor-test-1532283370486"],
"community":"steeditor"}

• from steemit steemd

{"tags":["not-utopian","not-analysis"],
"image":["https://steemitimages.com/0x0/https://user-images.githubusercontent.com/33018033/42889616-25f17de6-8aab-11e8-971e-e05abdb331e1.png"],
"links":["https://github.com/utopian-io/utopian.io","https://steemit.com/test/@stmdev/steeditor-test-1532283370486"],
"app":"steemit/0.1",
"format":"markdown"}

Differences:

• The steeditor metadata doesn't contain the repository in the links section, so the target repository may be empty or possibly wrong in the utopian review sheet. The steemit metadata contains the repository as the first entry in links
• The steeditor metadata detects a user mention in the markdown link for @stmdev, while steemit treats this as part of the URL and doesn't add a users field.

Environement

steeditor.app as live on 2018-08-29
Chrome 68.0

Expected behavior

Loading templates and drafts at the same time should load them correctly and return them to a method which engaged loading.

Actual behavior

When templates and drafts are loaded at the same time, a method which engaged the loading receives randomly either drafts or templates.

Expected behavior

Steeditor builds a permlink from the post title. However, not all characters are allowed in permlinks. Steeditor should allow any characters in the title and replace invalid permlink characters to form a working permlink from the title.

Actual behavior

Underscore (_) chars from the title are not allowed in the permlink and are not replaced. The comment broadcast call to SteemConnect returns code 500 with {"error":"server_error","error_description":"false: Invalid permlink character: _"} and Steeditor shows an error:

How to reproduce

Try to submit a post with underscores in the title, e.g.

NB: steemit replaces underscores with "-".

Environment

Chrome 69.0
Steeditor as live on https://steeditor.app on 18-10-09

Hi,
I recently start writing for projects via utopian, may I provide some documentation like FAQ for this project.
You may also request other forms of documents needed for the project.

The MVP should implement some of the features of a Progressive Web App.

• there should be a service worker registered
• there should be manifest.json (need a logo for that)
• without internet connection, user should be able to make CRUD operations on drafts

Project should have a basic setup.

• create basic project structure:
  • core module
• install and setup @ngrx/store, @ngrx/router-store, @ngrx/store-devtools, and @ngrx/effects
• install @angular/material and setup material module
• create basic layout

While creating a post via the /drafts/editor route, multiple drafts are being created.

• change the implementation - posts made via the /drafts/editor route should not create any draft

There is a problem (probably with a SteemConnect, see https://github.com/steemit/steemconnect/issues/292) when broadcasting a draft with allow_votes set to false.

• temporarily disable the Allow votes slide toggle
• enable this option once again as soon as the fix is ready

When there are no beneficiaries specified, broadcasting results in an error.

• check whether beneficiaries are set up and based on that create proper extensions

When trying to set the account "utopian-io" as a beneficiary it gives the following error

Please type a valid username!

which is probably caused by the "-".

How about adding a beneficiary feature for those who comment on your post. You will set the max number of beneficiaries and beneficiary reward percentage. E.g, 1% beneficiary for the first 20 comments.

Expected behavior

"utopian.pay" should be a valid username when adding a beneficiary.

Actual behavior

"utopian.pay" is not a valid username.

Additional info

"." should be added as a valid char in beneficiary pattern validator.

Expected Behavior

Tags should prevent a user from entering all invalid special characters except one single - between two words.

Actual Behavior

Tags allow all special characters (!@$%^&*()) except for #. When trying to publish a post, steem throws a broadcast error without any details.

Steps to Reproduce

• Login to https://steeditor.app
• Select draft from the top menu and then proceed to select + in the bottom right corner to add a new draft.
• Turn off use template and click create.
• Enter any title and body text.
• Enter tags with special characters Ex. test/test
• Click on Next twice to go to summary section and click Send.
• Notice the broadcast error at the bottom of the page.

Proposed fix:

Use following regex for testing a valid tag: /^[a-z0-9]+(-[a-z0-9]+)*$/

Recording of the issue

• Browser: Google Chrome ( 69.0.3497.81 Version)
• Operating system: OSX 10.11.6

Expected behavior

The community field in the post's json_metadata is (from Steem-perspective) only required to be valid JSON, there is no restriction on characters or formats from the blockchain implementation: https://github.com/steemit/steem/blob/c6b865b6f27999cba38f3840151c8306f14f3371/libraries/protocol/steem_operations.cpp#L86

Actual behavior

Steeditor requires the community field to consist of lower case chars only and shows an error message when other chars are used.
While lower-case chars only is quite common for the community field across apps, not all apps do this. Actifit for example uses a list in the community field. The blockchain allows any content as long as the resulting json_metadata is valid JSON.

How to reproduce

Enter upper case or special chars in the community field

Corresponding check in the code:

My TS skills are not sufficient to provide a PR which ensures only valid JSON.

Environment

Browser: Chrome 68.0
Steeditor.app at rev. 6911916

Expected behavior

When trying to edit a post from my blog using the steeditor app, there shouldn't be issues with some posts due to its json metadata.

Actual behavior

If I try to open a post from Actifit app specifically, the editor freezes and I can't use it till I restart the app afresh.

How to reproduce

• Am not sure how to get a post with metadata like the one broadcasted by Actifit, it has " enclosing the metadata.

"{"community":["actifit"],"step_count":["12000"],"activity_type":["Cycling, Daily Activity"],"tags":["mcyusuf","health","fitness","cycling","actifit"],"heightUnit":["cm"],"weightUnit":["kg"],"chestUnit":["cm"],"waistUnit":["cm"],"thighsUnit":["cm"],"image":["https://cdn.steemitimages.com/DQma3XriZxvHMWep4xjALkgQ1foWoQf24Ksq24FyrkRMcH3/A-4.I.png"],"appType":"","actiCrVal":"5310f62f01b497b52017269777384951ebe27ecbcaa3f9859c06af05626b9352c91d171d947260330a21b2acf2f85367","app":"actifit/v0.3.1"}"

• Open steeditor and locate the post.
• Click the edit icon and notice the bug.

Recording of the Bug

https://youtu.be/uSiSM0E7rx8

Working environment

• Android 8.1 Oreo
• Chrome version 66.0.3359.158

Expected behavior

When a user opens an existing draft, the current thumbnail and post preview should be available immediately.

Actual behavior

When a user opens an existing draft, the current thumbnail and post preview aren't available immediately, but after a change in the form.

There should be a form for creating a post.

• it should use Angular Material Stepper component:
  1. title, content, tags
  2. thumbnail
  3. advanced options (allow votes, allow curation rewards, etc.)
• the Store should be updated if user doesn't type for 1 sec (title, content), and on change of other fields
• reactive form
• container and presentationals (OnPush)

There should be implemented OAuth2 implicit grant flow with SteemConnect.

• user should be able to log in via SteemConnect with scope comment + comment_options
• access token should be stored in cookies
• user should be able to broadcast

Normally, after you are done creating a post and you send it to the steem blockchain, you are given the option to remove draft, the button has not been clicking for over a week now .

Post's drafts should be stored locally.

• user should be able to create a draft
• they probably should be stored in IndexedDB

Hopefully self-explanatory. The tag "task-bug-hunting" produced using the template generator has two hyphens. It appears only one is allowed.