iron-ox / fadecandy_ros Goto Github PK

Thanks for making this package publicly available. What is the status of this package? Is there any plan for releasing this package?

We would like to continue our development based on this package and do the following:

• Split into fadecandy_driver, fadecandy_msgs
• Add serial number diagnostics
• Pep8 compliant styling according to the ros python guidelines

Would you be open to accept pull requests for this?

Thanks!

On the startup of the node, there are times when fadecandy failed to connect and you see a warning:

Failed to connect to Fadecandy device: Found Fadecandy device but could not connect; will retry every second

However, the fadecandy never connects. The only solution is to restart the node. This is different from #17 that it reconnects when you unplug and replug the fadecandy.

Could you do a release for:

• Melodic
• Noetic (not sure whether everything is py3 compatible)

09.06.20 15:46:08 (+0200)  ros  Traceback (most recent call last):
09.06.20 15:46:08 (+0200)  ros    File "/opt/Eurogroep/melodic/lib/fadecandy_driver/fadecandy_node", line 16, in <module>
09.06.20 15:46:08 (+0200)  ros      main()
09.06.20 15:46:08 (+0200)  ros    File "/opt/Eurogroep/melodic/lib/fadecandy_driver/fadecandy_node", line 11, in main
09.06.20 15:46:08 (+0200)  ros      node = FadecandyNode()
09.06.20 15:46:08 (+0200)  ros    File "/opt/Eurogroep/melodic/lib/python2.7/dist-packages/fadecandy_driver/fadecandy_node.py", line 24, in __init__
09.06.20 15:46:08 (+0200)  ros      self._diagnostic_updater.setHardwareID(self._driver.serial_number)
09.06.20 15:46:08 (+0200)  ros  AttributeError: FadecandyNode instance has no attribute '_driver'

Happens sometimes on restart.

Found the following error in our logs:

[ERROR][1611637215.353462]: bad callback: <bound method FadecandyNode._set_leds of <fadecandy_driver.fadecandy_node.FadecandyNode instance at 0x7fb126186410>>

Not sure how to reproduce this yet.

Hi,

I'm trying to bloom-release a the 0.2.0 version of this package but I do not have permissions to the https://github.com/iron-ox/fadecandy_ros-release repository . Could you help me with this? BTW, should we update the maintainers / authors in the package.xml. What do you think.

Thanks!

With the new C++ driver, I saw the following warning message pop up in dmesg when we start the fadecandy_node.

[431653.276171] usb 1-4: usbfs: process 10226 (fadecandy_node) did not claim interface 0 before use

To reproduce the issue, I restarted the fadecandy_node and looked up dmesg. Also, I saw the INTERFACE_NO assigned 0x01. But why is the driver trying to claim 0x00?

Hi,

We are thinking about refactoring this driver to C++ since it is eating quite some resources when having a lot of leds on sending resources on high rates. What do you think? Would you be open for a PR?

Hi,

I've ported the fadecandy_ros driver to ros2 in a fork https://github.com/eurogroep/fadecandy_ros/tree/ros2.

Can someone create a ros2 branch, so I can create a pr to merge the fork in this repo? @jonbinney @wongkaiweng @venkisagunner93