igrsoft / igrphototweaks Goto Github PK

For portrait image:
500x1000 -> If square crop => 500x500

For horizontal image:
1000x500 -> If square crop => 1000x1000 (should be 500x500)

hi,

I wanted to set the aspect ratio as 1:1 by default and it should be locked. How to achieve this. When first time image is selected the crop area is same as image view area I need that aspect ratio to be 1:1. Please help

Thanks

Ritika

Hi,

I have seen that but i want to know that when user select the image for
first time it is setting cropview as of imagesize. It is calculating
maxbounds (). I want to know how will it set 1:1 aspect ratio and lock it
by default.

Thanks
Ritika

If we select any image with any of mirrored orientation (upMirrored,leftMirrored,rightMirrored,bottomMirroed)
then it Does't gived correct output image.

How can I create a custom crop section after image picker?

@ikorich
Need possibility, to change the image dynamically. Cause I use your library in my VIPER project with custom navigation I need to set an image placeholder at first, and on completion set real image that I want to crop.

Questions:

• Can your library handle it?
• Maybe am I doing something wrong?
• If not your suggestions on how to do it without changing of library concept?

P.S. I'll make PR with your suggestions to fix this.

Thank you in advance.

Can you please add functionality to rotate it 90 degree on button click?
also flip the image with animation on button click?

Hi

Pods file are missing in the project

I created new pod file and new work space for example. After this pods issue got resolved, but after this horizontalDial was not available.

Anyone can help me out its little urgent !!

Thanks

If I am setting the aspect ratio to 16:9 , because i want to force user to maintain that aspect ration while selecting the image.

User is able to change the aspect ratio to something else other than 9:16

There should be Boolean variable for example shouldLockAspectRatio , If that variable is set to be true , User should not be able to change the aspect ratio.

Command /bin/sh failed with exit code 1
this error I got when install example project in simulator

Kindly help me with the case in which I want to change the number of crop lines with the change of aspect ratio

when i set slider to -90~90 the crop area do not match the image.
wish your help.

CGImage+IGRPhonoTweakExtension.swift
CGContext is null when cropping PNG file

App crash on click on crop button if i select image from screenshot folder its working fine if I select image via camera. Crash only in iOS 13 and above.

When we transform image & click on crop, it is crashing as context in CGImage+IGRPhonoTweakExtension.swift is nil.

Added Valid frame for Crop View, when user change size of it

I have added IGRPhotoTweaks to my project using cocoapods which downloading version '1.0.7'. But it does not contains updated code with Swift 4.2 support. I have attached screenshots here:

Screenshot 1:

Screenshot 2:

Screenshot 3:

Screenshot 4:

Screenshot 5:

When rotating the image clockwise / counter-clockwise by 90 degrees, it seems like the crop area cannot select the whole image (even using original aspect does not work) and is still bound to the initial image size. Is there a way to update the crop area bounds when the image is rotated? Thanks!

You can reproduce the issue by manually setting the angle value.

self.changedAngle(value: 90.0)

Hi!

I am currently building an app to measure the pixels in a cropped image. This is why I need to use some internal variables of the pod such as:

• internal lazy var photoView in the IGRPhotoTweakViewController.swift. Changed it to public lazy var photoView
• private(set) lazy var photoContentView in the IGRPhotoTweakView.swift. Changed it to public private(set) lazy var photoContentView

Do you think you can change this variables to public so I can still use the pod in the future to crop the image and still be able to obtain the pixels without having to modify the internal code you have created?
Also, I would like to thank you for this amazing program, it has helped me a lot! I will attach the files in which I did the changes from private to public in case you want to take a look.
podChanges.zip

Best regards,

Manuela

I can make it work in your Example, but when I use Pods to install in my project the functions are not available. Seems like it's not pushed to master Pod release?

IGRPhotoTweakViewController+AspectRatio swift file missing when install through pods in version 1.0.6.
Thus not able to use "lockAspectRatio" method.

I am trying to run this code and i have installed pods but i got error like in following image, Please Help.

Hello!
I using this func:
override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
super.viewWillTransition(to: size, with: coordinator)
coordinator.animate(alongsideTransition: nil, completion: (
{(context) in
self.view.layoutIfNeeded()
self.resetView()
self.resetAspectRect()
}
))
}
But sometimes(more often) AspectRect does not display correctly
How i can fix it?
Thanks!

Whenever user dragged to crop
it should zoop to fill screen same in photos app
or user change aspect ratio value from action sheet should also zoom to screen
how to implement this functionality.

The files from the example IGRPhotoTweaks folder are not the same as from the pod installation.

App getting crashed while cropping panorama image

Cropping is not working, just the border is shown when used inside a framework. Also, extensions methods are not recognized.

Hi!

I need to lock the crop area, so the user are not able to change the size. I want to set some fixed aspect ratios e.g. 16:9 and user should not be able to move the white lines. So the solution is "not" to set just:
self.lockAspectRatio(true). This will still allow users to move the white lines... I need to disable it completly. Is it possible?

i want to get the crop rect with orginal image base ;how can i do it?

Hi @ikorich

I resolved that issue for horizontal Dial.
I am facing few more issues like

Unknown class _TtC7Example25ExampleCropViewController in Interface Builder file.
2017-05-25 15:52:10.062683+0530 Example[266:8830] *** NSForwarding: warning: object 0x100096720 of class 'Example.ExampleCropViewController' does not implement methodSignatureForSelector: -- did you forget to declare the superclass of 'Example.ExampleCropViewController'?
2017-05-25 15:52:10.063087+0530 Example[266:8830] *** NSForwarding: warning: object 0x100096720 of class 'Example.ExampleCropViewController' does not implement doesNotRecognizeSelector: -- abort

One issue I resolved by making pickerview.allowsediting = true
but still I am not able to run example in my device.

Please let me know whats wrong ?

Thanks !!

i have cropRect with photoView.scrollView.contentOffset but in ipad and plus devices it returns wrong point

All the features are good.
Is there any way to get Swift5 support ?

After choosing an image from UIImagePicker, which will be passed to the IGRPhotoTweakViewController. The image will be shown in there but it loses its original quality. Does anyone have the answer?

The latest release of 1.0.6 is several checkins behind.

Can you create another release from master?