ideashower / sharekit Goto Github PK

Very nice library. I started developing mine a few weeks ago. You totally made me stop my own and use your one :P But you should definitely bring us some Google Buzz support! Maybe I will, I've to check how to contribute to your project. Keep up the great work.

When you first start and do not have an account setup and it is configured for xAuth and you are on an iPad. Open Sharekit. Click More. Click Twitter. That screen no matter how you work it will never go away. Logging in and hitting cancel does not work.

edit: same thing goes for emailing as well. and tumblr... basically any view controller (not facebook, because thats custom) presented on the ipad after viewing the menu...

Can we get it to say something cooler like "Check out this App, "?

If I click the share button and select Email, then click Cancel, and then click the share button again, click Email, and then Cancel, my app crashes:

25.07.10 07.38.20 App[40244] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[**NSCFDictionary layerDidBecomeVisible:]: unrecognized selector sent to instance 0x6f5ab50'
* Call stack at first throw:
(
0 CoreFoundation 0x0232b919 __exceptionPreprocess + 185
1 libobjc.A.dylib 0x02a5f5de objc_exception_throw + 47
2 CoreFoundation 0x0232d42b -[NSObject(NSObject) doesNotRecognizeSelector:] + 187
3 CoreFoundation 0x0229d116 __forwarding + 966
4 CoreFoundation 0x0229ccd2 _CF_forwarding_prep_0 + 50
5 QuartzCore 0x026f5c4d _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 116
6 QuartzCore 0x026f5c83 _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 170
7 QuartzCore 0x026f5c83 _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 170
8 QuartzCore 0x026f5c83 _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 170
9 QuartzCore 0x026f5c83 _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 170
10 QuartzCore 0x026f5c83 _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 170
11 QuartzCore 0x026f5c83 _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 170
12 QuartzCore 0x026f5c83 _ZL18CALayerMarkVisibleP7CALayerPN2CA11TransactionEb + 170
13 QuartzCore 0x026f6a91 _ZL19updateAddedSublayerPN2CA11TransactionEP7CALayerS3_j + 90
14 QuartzCore 0x026f67b3 _ZL21CALayerInsertSublayerP7CALayerS0_jPN2CA11TransactionE + 394
15 QuartzCore 0x026f65b6 -[CALayer addSublayer:] + 71
16 UIKit 0x00362948 -[UIView(Internal) _addSubview:positioned:relativeTo:] + 844
17 UIKit 0x00360d87 -[UIView(Hierarchy) addSubview:] + 57
18 UIKit 0x003bae41 -[UITransitionView transition:fromView:toView:] + 563
19 UIKit 0x005c78de -[UIWindowController transition:fromViewController:toViewController:target:didEndSelector:] + 5787
20 UIKit 0x003df492 -[UIViewController dismissModalViewControllerWithTransition:] + 2147
21 Forsvaret 0x00009357 -[SHK hideCurrentViewControllerAnimated:] + 215
22 Forsvaret 0x0001c8b5 -[SHKMail mailComposeController:didFinishWithResult:error:] + 101
23 MessageUI 0x028f7175 -[MFMailComposeRootViewController mailComposeControllerCompositionFinished:] + 422
24 MessageUI 0x028d8ff1 -[MFMailComposeController _close] + 266
25 UIKit 0x007ba896 -[UIActionSheet(Private) _buttonClicked:] + 258
26 UIKit 0x00332e14 -[UIApplication sendAction:to:from:forEvent:] + 119
27 UIKit 0x003bc6c8 -[UIControl sendAction:to:forEvent:] + 67
28 UIKit 0x003beb4a -[UIControl(Internal) _sendActionsForEvents:withEvent:] + 527
29 UIKit 0x003bd6f7 -[UIControl touchesEnded:withEvent:] + 458
30 UIKit 0x003562ff -[UIWindow _sendTouchesForEvent:] + 567
31 UIKit 0x003381ec -[UIApplication sendEvent:] + 447
32 UIKit 0x0033cac4 _UIApplicationHandleEvent + 7495
33 GraphicsServices 0x03020afa PurpleEventCallback + 1578
34 CoreFoundation 0x0230cdc4 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION + 52
35 CoreFoundation 0x0226d737 __CFRunLoopDoSource1 + 215
36 CoreFoundation 0x0226a9c3 __CFRunLoopRun + 979
37 CoreFoundation 0x0226a280 CFRunLoopRunSpecific + 208
38 CoreFoundation 0x0226a1a1 CFRunLoopRunInMode + 97
39 GraphicsServices 0x0301f2c8 GSEventRunModal + 217
40 GraphicsServices 0x0301f38d GSEventRun + 115
41 UIKit 0x00340b58 UIApplicationMain + 1160
42 Forsvaret 0x00001fa5 main + 117
43 Forsvaret 0x00001ef6 start + 54
)


I am in the process of trying to write TwitPic into Twitter, but have ran into a major stumbling block. It appears share kit has not been tested or at least twitter for share kit has not been tested on iOS4. It gets a SigAbrt. This is at least the case with the oAuth component as I have not been able to test with xAuth as my count does not have that enabled yet.

test

Not let user edit text going to twitter - Would like user to not be able to change this - for consistancy

SHKTwitter supports offline sharing, however the url cannot be shortened without an internet connection. Need a graceful workaround for this.

Add a Dropbox sharer

Comments in SHKConfig.h say that it's OK to leave out service credentials for services you don't want to support. But when I run the test app with no Facebook credentials, Facebook still shows up in the action sheet as a sharing option. Looking at SHKActionSheet's +actionForType and SHK's +favoriteSharersForType I see that this is because there's no check on whether credentials exist before showing the list of services.

I could work on a patch to fix this but there be any interest? Comments in SHKConfig.h lean pretty heavily toward supporting everything, so would a patch that made it easier to hide services be likely to be accepted, assuming it works?

If not, could the comments in SHKConfig.h please be changed so that they no longer indicate it's safe to leave out service credentials?

I get the idea of letting the user decide where to share. But I also think it's possible to offer too many choices, and that not all services make sense for all apps or all users.

Need a way to for users to logout of either all or a specific service. The latter would be the most ideal.

Any attempt to use the Delicious service results in an immediate dialog: Request Error: There was a problem requesting authorization from Delicious.

The console reads the following, citing an issue with the consumer key:
<0x7c0f190 SHKOAuthSharer.m:(108)> tokenRequestTicket Response Body: oauth_problem=consumer_key_rejected

For my iPad app I'd prefer UIModalPresentationFormSheet.

Share a URL
Select More...
Select Email
Press Cancel

The view isn't removed

When trying to share text with twitter, it will always fail unless I manually type other text into the textview presented. Any idea why that might be? I can type anything as long as it's not just a space and it will work, otherwise it always fails.

Facebook stores its session in a unique way, need to include this in the logout process. Maybe add a logout method to SHKSharer instead.

See comment.

Add support for sharing images in SHKTwitter with img.ly or yfrog

I went into services Edit mode and turned off Facebook and Twitter. When I bring up the Share ActionSheet again, buttons for these services still appear.

Here are the steps you should take before posting issues, this will help get your question/problem resolved a LOT quicker, thanks for your help.

1. Check the common (and easily fixed) issues listed here:
   http://getsharekit.com/support/#issues
2. Make sure you have the latest version of ShareKit.
   a. Open SHK.h
   b. At the top it defines SHK_VERSION @"X.X.X"
   c. Compare that with the version number listed on http://getsharekit.com/install
3. Confirm the issue is indeed with ShareKit and not a problem with your own project.
   a. Open the example project included with ShareKit
   b. Copy your SHKConfig file into the example project and build it
   c. Is the problem reproducible?
4. If it is a connection / oauth / service issue, turn on debugging to see what the service is replying with. Troubleshoot any error messages the service tells you (if any).
   http://getsharekit.com/support/#debug
5. Post your issue, please be as specific as possible.
   a. Include any crash logs
   b. Detail how to reproduce the issue
   c. Provide a test case if possible

It may be necessary to dismiss the UIActionSheet with dismissWithClickedButtonIndex:animated:. For an iPad app you do it to avoid having multiple popovers. For an iOS4 app you may want to dismiss when the app moves to the background. It would be nice to have a known constant for a button index that won't get interpreted as an action.

When selecting twitter from the list, nothing happens - what do I do now?

Do I have to collect the UN and PW of the user or is that handled by SHK?

In - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath

hideCurrentViewControllerAnimated should be called BEFORE shareItem. Otherwise it may miss closing the current view if shareItem opens a new one.

Simply swap lines 266 and 268

iOS 4.0 now supports in-app text messaging. I will look into adding this as a service and contributing it back to the repository.

Need to make it graceful enough to handle iOS 3.x (which can't use this service) as well as iOS 4.x devices that don't allow text messaging (such as the iPod touch).

It would be useful to be able to see what Twitter/Facebook/etc accounts are currently logged in. This goes hand in hand with being able to log out.

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFDictionary setObject:forKey:]: attempt to insert nil value (key: custom)'

in SHK.m: + (BOOL)addToOfflineQueue:(SHKItem *)item forSharer:(NSString *)sharerId

Add a Flickr sharer

Add an Evernote sharer

User is presented with the Twitter OAuth login. User decides to cancel for whatever reason (they forgot their password). The alert that their login failed is unnecessary.

Add Instapaper

Very simple API details are at http://blog.instapaper.com/post/73123968/read-later-api

The Delicious support is using v2 of the API which is OAuth. I can't for the life of me find any docs as to what the SHKDeliciousCallbackUrl is used for. From what I can tell the API setup should have the app as a desktop (not web-based) app. None of my Delicious calls work whether I use a Yahoo ID or a Delicious login.

Any idea where some relevant docs are (whatever you used when making it would be awesome)?

You can help translate ShareKit by submitting localizations. Add an strings file to the ShareKit.bundle and submit the fork.

After tapping share text to twitter, and logging in, and allowing the application to post, the next page in the webview is "Simply return you and enter the following PIN to complete the progress"

This is surely not good.

Can someone tell me the exact settings to put into twitter app settings or what to put into SHKConfig.h

Facebook currently supports URL and Image. The 'description' parameter would allow sharing of text as well, if I'm not mistaken.

The SHKItem.text could also be passed along with the URL and Image types. This would allow apps to prepopulate the FB dialog with text from the app.

The user name login prompt may change an entry, due to the UITextField using auto correction of entries.

e.g. My name is John, my username is john: the login prompt would autocorrect my username to John.

The ability to add an HTML text section for content would be helpful for types such as images which can be emailed. The ability to add text content to the email would help, as well as adding a link to the image or its content.

This would help with email or Facebooking images, allowing a link or other comments to be added with the image, especially for plugging the iPhone/iPad app or linking to iTunes.

Add support for Instapaper

nytimes.com URLs passed through bit.ly have a nyti.ms domain. I don't know if there are other examples.

I'd remove the check altogether. The user is going to see that the shortening failed. There's no need to give them another alert to click through.

The dialog has a SKIP button. Skipping still calls didSucceed even though it doesn't appear to post. Need to find a way to know that the action was canceled.

Logout? It doesn't exist. This is bad. very bad.

Hi all, apparently there is a bad access (a released pointer).
If i choose, in sharing a link:

Share -> More -> Pinboard (or read it more, or something that pop up the modal controller)

I set the root view controller in the main controller as:

[[SHK currentHelper] setRootViewController:self];

I Have a crash with

rogram received signal: “EXC_BAD_ACCESS”.
(gdb) where
#0 0x321068a8 in -UIWindowController transitionViewDidComplete:fromView:toView:
#1 0x3206a1b0 in -UITransitionView notifyDidCompleteTransition:
#2 0x3206a030 in -UITransitionView _didCompleteTransition:
#3 0x32106630 in -UITransitionView _transitionDidStop:finished:
#4 0x32056d78 in -UIViewAnimationState sendDelegateAnimationDidStop:finished:
#5 0x32056c10 in -UIViewAnimationState animationDidStop:finished:
#6 0x31b77064 in run_animation_callbacks ()
#7 0x31b76e6c in CA::timer_callback ()
#8 0x338ae4c2 in CFRunLoopRunSpecific ()
#9 0x338adc1e in CFRunLoopRunInMode ()
#10 0x3434e1c8 in GSEventRunModal ()
#11 0x32002c30 in -UIApplication _run
#12 0x32001230 in UIApplicationMain ()

in in the animation ? can someone confirms ?

bests
a.

Support building for Mac apps too

Tried sending some text in an email.... 'Send' did not close the emails.. but seconds later I heard the sent email woosh.

SHKMail was built while ShareKit's architecture was being worked through. It works fine but ideally it should use the standard shareKit template and simply subclass -(BOOL)send instead of each method.

NSXMLParserDelegate didn't formally exist prior to iOS 4.0.

• Opened the ShareKit project using the latest (3a6a746) source, Xcode 3.2.3 and Base SDK of iPhone Device 4.0
• Build and Run in Simulator
• Sharing Text
• Click share button
• Choose Facebook
• The following error message appears twice in the Console: : FT_Load_Glyph failed: glyph 65535: error 6.