icemanbsi / flutter_time_picker_spinner Goto Github PK

Hey there :)

Could you please provide a license, so that everyone knows if they can use your plugin.

Is it possible to implement scrolling even if the scroll animation is not completely finished?

Can you upgrade this package to null safety?

This type error occures when I want to launch my app:

Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

The widget renders fine, but onTimeChange() is getting called upon the initial widget build, without the user having touched the screen. Can I prevent this?

The visualisation is very weird on my iOS and gets stuck all the time. On Android it seems to work fine.

I used latest version of flutter_time_picker_spinner (1.0.6+1)

flutter doctor -v

✓] Flutter (Channel stable, 1.22.4, on macOS 11.0.1 20B29 darwin-x64, locale en-BE)
• Flutter version 1.22.4 at /Users/app/flutter
• Framework revision 1aafb3a8b9 (10 days ago), 2020-11-13 09:59:28 -0800
• Engine revision 2c956a31c0
• Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/merijnmestdagh/Library/Android/sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.2, Build version 12B45b
• CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (1 available)
• Merijn’s iPhone (mobile) • 00008020-0009601E1199002E • ios • iOS 13.4.1

I want to start moving it with animation after pick the time, is there a way to do that?

Time picker doesn't have vibration like iOS time picker =(

Hi @icemanbsi
Your package is really great, and I haven't experienced any issues related to it.
Just one thing I really need is that there should be an option in the UI to add colons between the time text.

Really appreciate your effort if you get into this.
Thanks

Из-за отступа перед часами (чч) , когда делаешь выравнивание посередине в контейнере виджет смещается вправо. Настройки: 24 формат, без секунд. Пробовала менять space от него ничего не зависит.

Hello! Thank you so much for the package. It is very helpful.

I was having a look into the main.dart file in the example folder and the "new" keyword is not necessary. The compiler will infer that for you.

Ref. https://livebook.manning.com/concept/flutter/new-keyword

Thanks again.

Good one.

But need customization like min date, max date and initial date. And by default current time is selecting, better not to select by default and let user can select it.

It´s working in different mobile phones, but not working with Samsung galaxy S20 FE 5G

../../../../../.pub-cache/hosted/pub.dartlang.org/flutter_time_picker_spinner-2.0.0/lib/flutter_time_picker_spinner.dart:221:22: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

• 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../fvm/versions/3.0.5/packages/flutter/lib/src/widgets/binding.dart').
  WidgetsBinding.instance!
  ^

Description

In README.md, the isShowSeconds property is mentioned twice under the Props section.

I would like to work on this issue, so can you please assign it to me?

Screenshots

i want to change time manually by using setstate, but setting "time" props of the widget in "onTimeChange" callback does not work

Hi @icemanbsi, thank you for making the plugin available.

While I was trying to implement it in one of our projects I get the following error:

I/flutter (22078): ══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
I/flutter (22078): The following assertion was thrown while handling a gesture:
I/flutter (22078): 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 492 pos 12: '_hold == null':
I/flutter (22078): is not true.
I/flutter (22078):
I/flutter (22078): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter (22078): more information in this error message to help you determine and fix the underlying cause.
I/flutter (22078): In either case, please report this assertion by filing a bug on GitHub:
I/flutter (22078):   https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter (22078):
I/flutter (22078): When the exception was thrown, this was the stack:
I/flutter (22078): #2      ScrollableState._handleDragStart 
package:flutter/…/widgets/scrollable.dart:492
I/flutter (22078): #3      DragGestureRecognizer._checkStart.<anonymous closure> 
package:flutter/…/gestures/monodrag.dart:364
I/flutter (22078): #4      GestureRecognizer.invokeCallback 
package:flutter/…/gestures/recognizer.dart:182
I/flutter (22078): #5      DragGestureRecognizer._checkStart 
package:flutter/…/gestures/monodrag.dart:364
I/flutter (22078): #6      DragGestureRecognizer.acceptGesture 
package:flutter/…/gestures/monodrag.dart:298
I/flutter (22078): #7      GestureArenaManager._resolveByDefault 
package:flutter/…/gestures/arena.dart:250
I/flutter (22078): #8      GestureArenaManager._tryToResolveArena.<anonymous closure> 
package:flutter/…/gestures/arena.dart:231
I/flutter (22078): (elided 12 frames from class _AssertionError and package dart:async)
I/flutter (22078):
I/flutter (22078): Handler: "onStart"
I/flutter (22078): Recognizer:
I/flutter (22078):   VerticalDragGestureRecognizer#e44da
I/flutter (22078): ════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter (22078): Another exception was thrown: 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 497 pos 12: '_hold == null || _drag == null': is not true.
I/chatty  (22078): uid=10202(org.appiko.setup) Thread-2 identical 10 lines
I/flutter (22078): Another exception was thrown: 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 497 pos 12: '_hold == null || _drag == null': is not true.
I/flutter (22078): Another exception was thrown: 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 503 pos 12: '_hold == null || _drag == null': is not true.

TimePickerSpinner(
              highlightedTextStyle:
                  TextStyle(fontSize: 28, color: Theme.of(context).accentColor),
              normalTextStyle: TextStyle(fontSize: 24),
              is24HourMode: false,
              isForce2Digits: true,
              minutesInterval: 5,
              onTimeChange: (time) {},
            );

Am I missing something?

I found the same behavior on the example app.