This is what my bundle analysis looks like before using your wonderful plugin:

And this is what it looks like after:

The question, of course, is why is that minified locales.js file being included in addition to the individual locale files?

I recognize that this isn't the responsibility of this plugin, but I'm curious if you have any insights or have seen this situation before. It's got to have something to do with one of my dependencies loading in moment in some dumb way.

Thanks.

The devDependency webpack was updated from 4.39.2 to 4.39.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

"Critical dependency: the request of a dependency is an expression"

Hey, I'm sure I'm doing something wrong here, but even using this plugin with webpack and moment I am still getting the locales directory in my output.

When I look in the node_modules/moment directory, I see two locale folders.

One in the root, and one in dist/locale

I'm not sure why there are two, but no matter what I do the locales in node_moduels/moment/dist/locale are always included.

This seems to only ignore the root node_modules/moment/locale folder.

Any ideas? I'm at a bit of a loss. Thank you very much

It would be cool if the loader had an option (just a boolean flag) that would inject a little runtime into the bundle that checks if the locale is present in the whitelist. If it's not, it would fetch an additional bundle containing the locale.

Not sure how this would work exactly so far as what would happen during the time that the main bundle loaded, but the fetch for the additional locale(s) is still in progress; does it just act like moment normally does and give some "locale missing" error, but once the fetch is complete give you the desired results? Or perhaps the module's evaluation is blocked until the locale is available (probably a terrible idea) or maybe an additional wrapper package for moment is created that exposes a promise which resolves when the desired locale is available—either imediately if the client's locale is in the whitelist, or after the fetch is complete.

Just a thought..

if my webpack.the build process is not holding on current dir

the plugin can not find "moment"

try to add the "relative" option

in your source code

// you dont actrully know where truly moment module
// just give an option. require.resolve the moment relative position
moment = require('moment');

[Edit: This seems to be related with WebPack in General, not with Angular]
When activating this module in an Angular 12 project, this results in a warning:

./node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:29834:15-36 - Warning: Critical dependency: the request of a dependency is an expression

When looking at webpack/webpack#196 this seems to be a webpack warning about a require statement using a dynamic path for loading, as this prohibits tree shaking. Maybe there is a way to implement this module's functionality without doing so?

The devDependency webpack was updated from 4.26.1 to 4.27.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi
Thank you for this brilliant plugin, it replaces the old hack we had until now :)

moment-timezone shares with moment a similar problem : the data comes packed with it, it's massive (901 Kb before gzip), and you can't choose just what you need.

There is Luxon, that is using the browser database, but it cant work on some browsers, including IE 11, and anyway it's a massive API change.

Here is what you have in the data :

more node_modules/moment-timezone/data/packed/latest.json

{
        "version": "2018g",
        "zones": [
                "Africa/Abidjan|LMT GMT|g.8 0|01|-2ldXH.Q|48e5",
                "Africa/Accra|LMT GMT +0020|.Q 0 -k|012121212121212121212121212121212121212121212121|-26BbX.8 6tzX.8 MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE 1BAk MnE 1C0k MnE 1BAk MnE 1BAk MnE|41e5",

In my case, instead of all the possible timezones in the world, I just need one, but I would be crazy to code the timezone specific rules, especially given that they can change.
Another use cas would be to have only the America/* timezones for example.

Do you think it's possible to write a plugin that would strip the data, based on an expression ?

Version 4.18.0 of webpack was just published.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

See https://lodash.com/per-method-packages for reasons for change.

I can send PR.

After update to 1.0.6. got an error in my webpack build pipeline:
Error: MomentLocalesPlugin: Moment.js doesn’t include a locale you specified: en. Check the plugin’s `localesToKeep` option.
I'm passing {localesToKeep:['en']} to the plugin config as before, was working fine pre-update, as the documentation suggests. So it's a regression error, I'd say.

There are some locales which names are included in any other locale names, so localesToKeep parameter bring them as well.

For instance:

new MomentLocalesPlugin({
    localesToKeep: ['ca'],
  })

You'll get en-ca and fr-ca, besides ca

I get the following error while trying to run my app using yarn version 2.

Error: moment-locales-webpack-plugin tried to access webpack (a peer dependency) but it isn't provided by your application; this makes the require call ambiguous and unsound.

Required package: webpack (via "webpack")
Required by: moment-locales-webpack-plugin@virtual:0ecb949dcbcde61e6cca55949c7becddcb7ebc4a3ef944a62f8dccb560a68ee2d76e2ca7f733ecd2b3ea36a022f329f0cf4d707ef69c07d1d9fbc1e55e943bdd#npm:1.2.0 (via /Users/mbamba/personal/work/monorepo/monorepo/.yarn/$$virtual/moment-locales-webpack-plugin-virtual-a0957a4bde/0/cache/moment-locales-webpack-plugin-npm-1.2.0-7c62d54698-a1613eaa41.zip/node_modules/moment-locales-webpack-plugin/)
Ancestor breaking the chain: @fe/client@workspace:packages/client
Ancestor breaking the chain: @fe/hotel@workspace:packages/hotel

Executing the MomentLocalesPlugin() in my project that i'm trying to test on Webpack V5 is throwing the following error:

 - options should be one of these:
   object { contextRegExp?, resourceRegExp? } | object { checkResource? }
ValidationError: Invalid options object. Ignore Plugin has been initialized using an options object that does not match the API schema.
    at validate (/Users/req/code/www/project.com/node_modules/webpack/node_modules/schema-utils/dist/validate.js:85:11)
    at new IgnorePlugin (/Users/req/code/www/project.com/node_modules/webpack/lib/IgnorePlugin.js:20:3)
    at new MomentLocalesPlugin (/Users/req/code/www/project.com/node_modules/moment-locales-webpack-plugin/index.js:118:16)
    at Object.<anonymous> (/Users/req/code/www/project.com/build-utils/webpack.common.js:112:9)
    at Module._compile (/Users/req/code/www/project.com/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (/Users/req/code/www/project.com/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
    at Object.<anonymous> (/Users/req/code/www/project.com/build-utils/webpack.dev.js:6:22)
    at Module._compile (/Users/req/code/www/project.com/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (/Users/req/code/www/project.com/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
    at /Users/req/code/www/project.com/webpack.config.js:23:25
    at Array.forEach (<anonymous>)
    at module.exports (/Users/req/code/www/project.com/webpack.config.js:20:13)
    at handleFunction (/Users/req/code/www/project.com/node_modules/webpack-cli/bin/utils/prepareOptions.js:21:13)
    at prepareOptions (/Users/req/code/www/project.com/node_modules/webpack-cli/bin/utils/prepareOptions.js:9:5)
    at requireConfig (/Users/req/code/www/project.com/node_modules/webpack-cli/bin/utils/convert-argv.js:117:14)
    at /Users/req/code/www/project.com/node_modules/webpack-cli/bin/utils/convert-argv.js:123:17
    at Array.forEach (<anonymous>)
    at module.exports (/Users/req/code/www/project.com/node_modules/webpack-cli/bin/utils/convert-argv.js:121:15)
    at /Users/req/code/www/project.com/node_modules/webpack-cli/bin/cli.js:71:45
    at Object.parse (/Users/req/code/www/project.com/node_modules/webpack-cli/node_modules/yargs/yargs.js:567:18)
    at /Users/req/code/www/project.com/node_modules/webpack-cli/bin/cli.js:49:8
    at Object.<anonymous> (/Users/req/code/www/project.com/node_modules/webpack-cli/bin/cli.js:366:3)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18) 

Where this get's really silly, webpack updated their documentation on how to fix this issue, and it pretty cleanly translates to this package:

webpack/webpack.js.org@9dc398b
https://webpack.js.org/plugins/ignore-plugin/

Occurs on https://github.com/iamakulov/moment-locales-webpack-plugin/blob/master/index.js#L118

We use this plugin on moment-module to Nuxt.js

Problem:
nuxt-community/moment-module#25

This is because of this line
https://github.com/iamakulov/moment-locales-webpack-plugin/blob/master/index.js#L64

Can we have an option not to check the current locale?

There is a Webpack deprecation warning DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET:

(node:15570) [DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET] DeprecationWarning: Compilation.modules was changed from Array to Set (using Array method 'map' is deprecated)

It can be fixed by small change in utils.js:

- const modulePaths = stats.compilation.modules
+ const modulePaths = Array.from(stats.compilation.modules)

But I think it will require a major version update.

The devDependency webpack was updated from 4.35.3 to 4.36.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴