We use this plugin on moment

Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

ERROR: MomentLocalesPlugin: Moment.js doesn’t include a locale you specified about moment-locales-webpack-plugin HOT 5 CLOSED

iamakulov commented on June 3, 2024

ERROR: MomentLocalesPlugin: Moment.js doesn’t include a locale you specified

from moment-locales-webpack-plugin.

Comments (5)

iamakulov commented on June 3, 2024

Hey @ricardogobbosouza! Sorry, missed your issue – my inbox’s a mess right now 😬

I’ve drafted #24 as a potential solution to the issue. Here’s the test that (I assume) covers your use-case:

moment-locales-webpack-plugin/test/test.js

Lines 116 to 128 in e480472

 // This handles https://github.com/iamakulov/moment-locales-webpack-plugin/issues/23 

 test('does not throw when someone changes the global locale before the build', async () => { 

 const moment = require('moment'); 

 moment.locale('de-ch'); 

 expect(() => { 

 new MomentLocalesPlugin({ 

 localesToKeep: ['de-ch'], 

 }); 

 }).not.toThrow(); 

 expect(moment.locale()).toBe('de-ch'); 

 });

Could you confirm whether it solves the issue you’re having? If you want to test it locally, this patch is available in npm under [email protected].

I’ll be happy to publish 1.1.2 as soon as you confirm this works for you.

from moment-locales-webpack-plugin.

ricardogobbosouza commented on June 3, 2024

@iamakulov thanks
I will test

from moment-locales-webpack-plugin.

ricardogobbosouza commented on June 3, 2024

@iamakulov its works 😄

from moment-locales-webpack-plugin.

iamakulov commented on June 3, 2024

Just released a @1.1.2 with the fix!

from moment-locales-webpack-plugin.

ricardogobbosouza commented on June 3, 2024

thanks @iamakulov

from moment-locales-webpack-plugin.

ERROR: MomentLocalesPlugin: Moment.js doesn’t include a locale you specified about moment-locales-webpack-plugin HOT 5 CLOSED

Comments (5)

Related Issues (18)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// This handles https://github.com/iamakulov/moment-locales-webpack-plugin/issues/23
	test('does not throw when someone changes the global locale before the build', async () => {
	const moment = require('moment');
	moment.locale('de-ch');

	expect(() => {
	new MomentLocalesPlugin({
	localesToKeep: ['de-ch'],
	});
	}).not.toThrow();

	expect(moment.locale()).toBe('de-ch');
	});